rh-che #703: Adding support of 'Impersonate-*' headers processing in OpenShift infrastructure#10010
Merged
ibuziuk merged 1 commit intoeclipse-che:masterfrom Jun 13, 2018
Merged
Conversation
|
Can one of the admins verify this patch? |
davidfestal
approved these changes
Jun 12, 2018
|
Can one of the admins verify this patch? |
sleshchenko
approved these changes
Jun 12, 2018
benoitf
added
kind/enhancement
…cessing Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
l0rd
approved these changes
Jun 12, 2018
Member
Author
|
ci-test |
|
ci-test build report: |
Member
Author
|
ci-test |
|
ci-test build report: |
Member
Author
|
ci-test |
|
ci-test build report: |
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding support of 'Impersonate-*' headers processing via
ImpersonatorInterceptorStrarting from ther version
3.1.7of kubernetes-client there is a support ofImpersonate-*headers viaImpersonatorInterceptor[1] [2]. After updating kubernetes-client to the latest3.1.12version there is a possibility to support this functionality in OpenShift client that is used in Che[1] https://github.com/fabric8io/kubernetes-client/blob/master/openshift-client/src/main/java/io/fabric8/openshift/client/DefaultOpenShiftClient.java#L256
[2] https://github.com/fabric8io/kubernetes-client/blob/master/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/utils/ImpersonatorInterceptor.java#L36
What issues does this PR fix or reference?
redhat-developer/rh-che#703
More details could be found in the following rh-che PR redhat-developer/rh-che#688
Release Notes
Support of 'Impersonate-*' headers processing in OpenShift infrastructure
Docs PR
N/A