Skip to content

Make ws agent-master interaction more consistent#10031

Merged
gazarenkov merged 3 commits intoeclipse-che:masterfrom
gazarenkov:master
Jun 16, 2018
Merged

Make ws agent-master interaction more consistent#10031
gazarenkov merged 3 commits intoeclipse-che:masterfrom
gazarenkov:master

Conversation

@gazarenkov
Copy link
Copy Markdown
Contributor

@gazarenkov gazarenkov commented Jun 13, 2018

What does this PR do?

  • avoid additional remote call of workspace API
  • make design more clean splitting interfaces for syncing projects and retrieving runtime
  • remove unused methods

@gazarenkov gazarenkov requested a review from evidolob as a code owner June 13, 2018 19:24
@gazarenkov gazarenkov removed the request for review from evidolob June 13, 2018 19:24
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 13, 2018
@vparfonov
Copy link
Copy Markdown
Contributor

vparfonov commented Jun 13, 2018

ci-test

@codenvy-ci
Copy link
Copy Markdown

codenvy-ci commented Jun 14, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10031
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov
Copy link
Copy Markdown
Contributor

vparfonov commented Jun 14, 2018

Basically ok for me, except name of class WorkspaceProjectSynchronizer now also will return workspace Runtime

@gazarenkov
Copy link
Copy Markdown
Contributor Author

gazarenkov commented Jun 14, 2018

@vparfonov if you mean naming, well I tried to reduce confusing making it implement WorkspaceKeeper so it looks quite legitimate now. Otherwise - if you can see better than WorkspaceProjectSynchronizer name - go ahead.

@eclipse-che eclipse-che deleted a comment from Tarrantella Jun 15, 2018
@musienko-maxim
Copy link
Copy Markdown
Contributor

musienko-maxim commented Jun 15, 2018

ci-test

@codenvy-ci
Copy link
Copy Markdown

codenvy-ci commented Jun 15, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10031
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@musienko-maxim
Copy link
Copy Markdown
Contributor

musienko-maxim commented Jun 15, 2018

ci-test

@codenvy-ci
Copy link
Copy Markdown

codenvy-ci commented Jun 15, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10031
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@gazarenkov gazarenkov merged commit c3a982c into eclipse-che:master Jun 16, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 16, 2018
@benoitf benoitf added this to the 6.7.0 milestone Jun 16, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
@gazarenkov
Make ws agent-master interaction more consistent (eclipse-che#10031)
7ab83b8 
* Make ws master-agent interactions more consistent

* clean commented

* fix getting projects from workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vparfonov vparfonov vparfonov approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@dkulieshov dkulieshov Awaiting requested review from dkulieshov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

6 participants

@gazarenkov @vparfonov @codenvy-ci @musienko-maxim @dkulieshov @benoitf