CHE-LIB-57: Update xterm.js to the version 3.3.0 by AndrienkoAleksandr · Pull Request #10037 · eclipse-che/che

AndrienkoAleksandr · 2018-06-14T07:46:58Z

What does this PR do?

Update xterm.js to the version 3.3.0

What issues does this PR fix or reference?

eclipse-che/che-lib#57

Release Notes

Update xterm.js to the version 3.3.0

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr · 2018-06-15T07:23:32Z

ci-test

codenvy-ci · 2018-06-15T12:32:02Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10037
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

AndrienkoAleksandr · 2018-06-15T13:51:16Z

@musienko-maxim, Could you check report, please?

musienko-maxim · 2018-07-10T13:57:22Z

All tests that depended on terminal fault (that was expected, because current implementation of the terminal uses canvas instead of DOM element). So we should find way to adapt tests for the current implementation of the terminal.

musienko-maxim · 2018-07-10T13:58:24Z

We can start adaptation after resolving the issue: #10258

musienko-maxim

Should be merged after fixing the issue: #10258 and adaptation dependent tests

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp · 2018-08-04T09:00:49Z

ci-test

riuvshin · 2018-08-04T11:11:28Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10037
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-08-04T13:41:03Z

ci-test

riuvshin · 2018-08-04T18:59:31Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10037
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-08-04T21:13:07Z

ci-test

riuvshin · 2018-08-05T06:55:18Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10037
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp · 2018-08-08T13:53:56Z

ci-test

riuvshin · 2018-08-09T01:33:49Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10037
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp · 2018-08-09T14:27:56Z

ci-test

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

riuvshin · 2018-08-09T20:51:29Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10037
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-08-10T15:31:48Z

ci-test

riuvshin · 2018-08-10T17:51:39Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10037
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-08-11T20:50:37Z

ci-test

riuvshin · 2018-08-12T01:51:59Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10037
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-08-12T09:52:16Z

ci-test

riuvshin · 2018-08-12T15:52:09Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10037
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

AndrienkoAleksandr added 10 commits June 13, 2018 13:59

Use xterm.js 3.3.0, but with default styles.

6663f52

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Set terminal theme.

11d9150

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Configure font

b340b0d

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Activate custom key event handler.

32d28c6

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Rework resize mehanizm.

f6e26d4

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Code clean up: remove focus timer - it was workaround for older xterm.js

946ce89

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Fix cursor position after switch to another tabs.

9fb1d3e

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Little optimization.

a7c5afc

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Merge branch 'master' of github.com:eclipse/che into CHE-LIB-57-3

ebf41dd

Fix format apply a bit docs.

15542be

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

AndrienkoAleksandr requested a review from vparfonov as a code owner June 14, 2018 07:46

AndrienkoAleksandr requested review from azatsarynnyy and mmorhun June 14, 2018 07:47

benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 14, 2018

AndrienkoAleksandr mentioned this pull request Jun 14, 2018

Fix selenium test after update xterm.js from 2.4.0 to 3.3.0 version. #9909

Closed

mmorhun approved these changes Jun 14, 2018

View reviewed changes

azatsarynnyy approved these changes Jun 14, 2018

View reviewed changes

vparfonov approved these changes Jun 15, 2018

View reviewed changes

AndrienkoAleksandr requested a review from musienko-maxim June 15, 2018 13:50

AndrienkoAleksandr mentioned this pull request Jul 4, 2018

Apply javascript method. #10258

Closed

vkuznyetsov mentioned this pull request Jul 10, 2018

Impossible to copy/paste into Terminal #9398

Closed

musienko-maxim requested changes Jul 10, 2018

View reviewed changes

ashumilova mentioned this pull request Jul 11, 2018

IDE2-2018-07-31 (Sprint: 152) #10348

Closed

20 tasks

AndrienkoAleksandr added 2 commits July 20, 2018 15:06

Merge branch 'master' of github.com:eclipse/che into CHE-LIB-57-3

052033c

Fix compilation.

e3febe1

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

Fix formatting of CheTerminal.java

5534822

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Dmytro Nochevnov added 2 commits August 6, 2018 18:18

Fix OpenInTerminalTest by taking into account the number of terminal tab

f76299b

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Fix WorkingWithTerminalTest after renewal of version of xterm

e6c33d5

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp force-pushed the CHE-LIB-57-3 branch from acd8239 to e6c33d5 Compare August 8, 2018 08:38

Dmytro Nochevnov added 2 commits August 8, 2018 15:23

Fix WorkingWithSplitPanelTest after renewal of version of xterm

0a84330

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Merge remote-tracking branch 'origin/master' into CHE-LIB-57-3

afaef51

Fix verification that mc is opened

23b2fa8

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Adapt terminal related selenium tests to K8S infrastructure

9f1f324

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

musienko-maxim approved these changes Aug 10, 2018

View reviewed changes

Merge remote-tracking branch 'origin/master' into CHE-LIB-57-3

c22d609

vparfonov approved these changes Aug 13, 2018

View reviewed changes

dmytro-ndp approved these changes Aug 13, 2018

View reviewed changes

AndrienkoAleksandr merged commit dda4038 into master Aug 15, 2018

skabashnyuk deleted the CHE-LIB-57-3 branch August 16, 2018 07:08

Conversation

AndrienkoAleksandr commented Jun 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Uh oh!

AndrienkoAleksandr commented Jun 15, 2018

Uh oh!

codenvy-ci commented Jun 15, 2018

Uh oh!

AndrienkoAleksandr commented Jun 15, 2018

Uh oh!

musienko-maxim commented Jul 10, 2018

Uh oh!

musienko-maxim commented Jul 10, 2018

Uh oh!

musienko-maxim left a comment

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp commented Aug 4, 2018

Uh oh!

riuvshin commented Aug 4, 2018

Uh oh!

dmytro-ndp commented Aug 4, 2018

Uh oh!

riuvshin commented Aug 4, 2018

Uh oh!

dmytro-ndp commented Aug 4, 2018

Uh oh!

riuvshin commented Aug 5, 2018

Uh oh!

dmytro-ndp commented Aug 8, 2018

Uh oh!

riuvshin commented Aug 9, 2018

Uh oh!

dmytro-ndp commented Aug 9, 2018

Uh oh!

riuvshin commented Aug 9, 2018

Uh oh!

dmytro-ndp commented Aug 10, 2018

Uh oh!

riuvshin commented Aug 10, 2018

Uh oh!

dmytro-ndp commented Aug 11, 2018

Uh oh!

riuvshin commented Aug 12, 2018

Uh oh!

dmytro-ndp commented Aug 12, 2018

Uh oh!

riuvshin commented Aug 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

AndrienkoAleksandr commented Jun 14, 2018 •

edited

Loading