Skip to content

Fix for formatting for python language servers#10060

Merged
dkulieshov merged 2 commits intomasterfrom
che#9854
Jun 20, 2018
Merged

Fix for formatting for python language servers#10060
dkulieshov merged 2 commits intomasterfrom
che#9854

Conversation

@dkulieshov
Copy link
Copy Markdown

Related issue: #9854

Fixed full text formatting by correcting endLine and endCharacter values.

Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
@dkulieshov dkulieshov requested a review from evidolob as a code owner June 15, 2018 12:26
@dkulieshov dkulieshov requested a review from vparfonov June 15, 2018 12:26
@dkulieshov
Copy link
Copy Markdown
Author

ci-test

@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jun 15, 2018
@vparfonov vparfonov removed the request for review from evidolob June 15, 2018 13:09
@codenvy-ci
Copy link
Copy Markdown

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10060
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Copy Markdown
Contributor

SkorikSergey commented Jun 18, 2018

We've found regression in the C language server, after applying a formatting to C++ code, the content in the editor becomes broken.

Reproduction Steps

  1. Create workspace from C++ stack with console-cpp-simple project.
  2. Enable Clangd language server installer if it need.
  3. Open hello.cc file and add next content:
                  int isEven(int x)     {
    return x % 2 ==               0;
                    }
  1. Apply Edit -> Format.

Expected result: The content should be

    int isEven(int x) { return x % 2 == 0; }

Actual result: The formatting is not applied correctly.

Additional information:
screencast-172 19 20 234-8080-2018 06 18-15-57-36

@musienko-maxim
Copy link
Copy Markdown
Contributor

musienko-maxim commented Jun 18, 2018

So, we check all existed selenium tests and checked all usecases according to manual test plan for language servers: https://github.com/eclipse/che/wiki/Test-plan-for-checking-Language-servers.
Other bugs, except described above, are not be found.
The testcase above works properly on the master.

…dits

Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
@dkulieshov
Copy link
Copy Markdown
Author

ci-test

@codenvy-ci
Copy link
Copy Markdown

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10060
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@musienko-maxim
Copy link
Copy Markdown
Contributor

musienko-maxim commented Jun 20, 2018

The existed selenium tests did not find new regression. During manual test plan we did not find new bugs.
But during test session was created new issue: #10086

@dkulieshov dkulieshov merged commit ad0a637 into master Jun 20, 2018
@dkulieshov dkulieshov deleted the che#9854 branch June 20, 2018 14:06
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 20, 2018
@benoitf benoitf added this to the 6.8.0 milestone Jun 20, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants