Show warning dialog after refactoring operation if something isn't valid#10080
Merged
svor merged 2 commits into5730_java_ls_pocfrom Jun 20, 2018
Merged
Show warning dialog after refactoring operation if something isn't valid#10080svor merged 2 commits into5730_java_ls_pocfrom
svor merged 2 commits into5730_java_ls_pocfrom
Conversation
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
benoitf
added
status/code-review
tolusha
approved these changes
Jun 18, 2018
tsmaeder
approved these changes
Jun 20, 2018
| undoChanges(); | ||
| applyWorkspaceEditAction.applyWorkspaceEdit(edits); | ||
| RefactoringStatus refactoringStatus = result.getRefactoringStatus(); | ||
| if (!FATAL.equals(refactoringStatus.getRefactoringSeverity())) { |
Contributor
There was a problem hiding this comment.
How do we inform the user that something went wrong in this case?
Contributor
Author
There was a problem hiding this comment.
added a way to show notification with an error message
svor
removed
the
status/code-review
tsmaeder
pushed a commit
that referenced
this pull request
Jun 26, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Jul 13, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Jul 27, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tolusha
pushed a commit
that referenced
this pull request
Aug 7, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Aug 22, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Aug 29, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tolusha
pushed a commit
that referenced
this pull request
Sep 5, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 13, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 20, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Sep 26, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 1, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 5, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 12, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 16, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
…lid (#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
(#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
(#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder
pushed a commit
that referenced
this pull request
Oct 17, 2018
(#10080) Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Valeriy Svydenko vsvydenk@redhat.com
What does this PR do?
After preparing changes of refactoring operation it may have some error/warning status. So the main idea of current PR is to show warning dialog before applying changes.
What issues does this PR fix or reference?
#10034