Merged
Conversation
Fixes eclipse-che#10083 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
benoitf
added
the
status/code-review
Contributor
|
ci-test |
|
ci-test build report: |
dkulieshov
approved these changes
Jun 27, 2018
skabashnyuk
approved these changes
Jun 27, 2018
|
Tests look normal. Merging. |
ghost
merged commit
benoitf
removed
the
status/code-review
benoitf
added
the
kind/bug
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10083
Signed-off-by: Victor Rubezhny vrubezhny@redhat.com
What does this PR do?
The fix disables to provide null as message argument of JsonRpcError and insures that null value cannot be passed there in JsonRpcErrorTransmitter.transmit()
What issues does this PR fix or reference?
Fixes #10083
Release Notes
The fix disables to provide null as message argument of JsonRpcError and insures that null value cannot be passed there in JsonRpcErrorTransmitter.transmit()
Docs PR