Conversation
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
added
kind/bug
Contributor
Author
|
ci-build |
Contributor
Author
|
ci-test |
benoitf
added
the
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4555/ |
|
ci-test build report: |
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Contributor
Author
|
ci-test |
Contributor
Author
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4557/ |
|
ci-test build report: |
vparfonov
approved these changes
Jun 21, 2018
musienko-maxim
approved these changes
Jun 22, 2018
benoitf
removed
the
status/code-review
ScrewTSW
pushed a commit
to ScrewTSW/che
that referenced
this pull request
Jun 25, 2018
* Show build details in dedicate window Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * New Line Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * New Line Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * New Line Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Add debug id to the anchor Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Adopt Dialog About selenium test to actual changes on the UI Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> Modified TestWorkspaceProvider -> Abstraction, so that rh-che can override needed methods. Modified TestWorkspaceServiceClient for rh-che tests extension Abstracted TestWorkspaceServiceClient for RhChe implementation Fixed inject issues Signed-off-by: Tibor Dancs <tdancs@redhat.com> Modified required abstractions, using interfaces instead of implementations of the interface (e.g. DefaultTestUser) Modified TestWorkspaceProvider -> Abstraction, so that rh-che can override needed methods. Fixed inject issues Signed-off-by: Tibor Dancs <tdancs@redhat.com>
ScrewTSW
pushed a commit
to ScrewTSW/che
that referenced
this pull request
Jun 25, 2018
* Show build details in dedicate window Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * New Line Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * New Line Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * New Line Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Add debug id to the anchor Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Adopt Dialog About selenium test to actual changes on the UI Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> Modified TestWorkspaceProvider -> Abstraction, so that rh-che can override needed methods. Modified TestWorkspaceServiceClient for rh-che tests extension Abstracted TestWorkspaceServiceClient for RhChe implementation Fixed inject issues Signed-off-by: Tibor Dancs <tdancs@redhat.com> Modified required abstractions, using interfaces instead of implementations of the interface (e.g. DefaultTestUser) Modified TestWorkspaceProvider -> Abstraction, so that rh-che can override needed methods. Fixed inject issues Signed-off-by: Tibor Dancs <tdancs@redhat.com>
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
* Show build details in dedicate window Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * New Line Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * New Line Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * New Line Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Add debug id to the anchor Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com> * Adopt Dialog About selenium test to actual changes on the UI Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes proposal modifies standard about dialog by adding dedicated window to display build details information, such as revision, version, build time.
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
What issues does this PR fix or reference?
#9727
Release Notes
Show build details in dedicate window from Help-About command
Docs PR
N/A