Basic support of the Eclipse Ceylon language#10096
Basic support of the Eclipse Ceylon language#10096davidfestal merged 9 commits intoeclipse-che:masterfrom
Conversation
davidfestal
requested review from
riuvshin,
skabashnyuk and
vparfonov
as code owners
|
Can one of the admins verify this patch? |
benoitf
added
the
status/code-review
|
ci-test |
|
ci-test build report: |
|
@davidfestal please let us know when this PR would be ready to review. |
|
ci-test |
|
ci-test build report: |
|
ci-test |
|
ci-test build report: |
@skabashnyuk according to the last build, it seems ready to review. |
| <artifactId>license-maven-plugin</artifactId> | ||
| <configuration> | ||
| <excludes> | ||
| <exclude>**/ceylon.svg</exclude> |
There was a problem hiding this comment.
Who made this file? Who own a copyright for it?
There was a problem hiding this comment.
It's the extact same file as the one already added in this PR: #5844 (comment)
Also see this answer to a question from @benoitf : #5844 (comment)
| <excludes> | ||
| <!-- The files don't need a license since they will | ||
| be added as templates inside the user projects --> | ||
| <exclude>src/main/resources/project/**</exclude> |
There was a problem hiding this comment.
can you put a license in comments of templates?
There was a problem hiding this comment.
IMHO generated code is unlicensed. Each user is making the choice of the license to use for their project.
Generator library is licensed but not why user find as its "project files"
plugins/plugin-ceylon/pom.xml
Outdated
| <parent> | ||
| <artifactId>che-plugin-parent</artifactId> | ||
| <groupId>org.eclipse.che.plugin</groupId> | ||
| <version>6.7.0-SNAPSHOT</version> |
There was a problem hiding this comment.
here need to set new version 6.8.0-SNAPSHOT
- language description, - syntax highlighting, - project creation. Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
ceylon-support-step1
branch
from
0715968 to
aa7f43f
Compare
|
ci-test |
|
ci-test build report: |
Signed-off-by: David Festal <dfestal@redhat.com>
|
ci-test |
|
ci-test build report: |
benoitf
removed
the
status/code-review
Basic support of the Eclipse Ceylon language support, with the following features: - language description, - syntax highlighting, - project creation. Signed-off-by: David Festal <dfestal@redhat.com>
6 participants
What does this PR do?
This PR adds basic support of the Eclipse Ceylon language in Eclipse Che:
What issues does this PR fix or reference?
It refers no issue and is a new feature contribution
Release Notes
Basic support of the Eclipse Ceylon language in Eclipse Che with: