Conversation
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
requested review from
a user,
AndrienkoAleksandr,
benoitf,
garagatyi and
riuvshin
| cd /home/default/theia && \ | ||
| yarn && \ | ||
| yarn theia build | ||
| RUN find ${YARN_CACHE_FOLDER} -exec sh -c "chgrp 0 {}; chmod g+rwX {}" \; |
There was a problem hiding this comment.
should we group all RUN instructions together ?
There was a problem hiding this comment.
Do not think so. It could be helpful if we add something and then delete it at the end of RUN. But in this case it still remains we cannot reduce image size. What we will have - a single layer with all the changes, which is not so good, because it makes using caches harder.
There was a problem hiding this comment.
well I still think using one layer will be better as BTW each time package.json is changed it will update yarn cache and then it will be invalidated
There was a problem hiding this comment.
But it will happen anyway and doesn't depend on number of layers...
benoitf
added
status/code-review
|
I think it doesn't solve issue on write access on some folder |
|
@benoitf it is not backport of https://github.com/theia-demo-plugins/wiptheia-docker-image/blob/master/Dockerfile. This PR solves problems with caches on openshift. |
|
@mmorhun I mean that it solves one issue but other issues on openshift remain |
|
also now that plugin's model has been merged this image will be replaced by the wip docker image. |
|
We shouldn't replace this dockerfile with wiptheia one. Otherwise we'll lose fix for caches problem. I think we should merge them but I would like to do it in a separate PR. |
|
@mmorhun yes when I said "replaced" it was more "merge" |
|
but my meaning was more that we could have fixed wip dockerimage and then drop this one and use the new one. As this image is more broken than the wip-dockerimage |
|
Yes, I agree that we have better image in wiptheia than here in Che and it definitely should be considered. |
benoitf
left a comment
benoitf
left a comment
There was a problem hiding this comment.
would be better by merging RUN but can be reworked with the upcoming merge
benoitf
removed
the
status/code-review
…se-che#10116) Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
4 participants
What does this PR do?
Adds settings and corresponding permissions into docker image with Theia to be able to use yarn cache on openshift
What issues does this PR fix or reference?
#9978