Selenium: Fix of unexpected fail of "AddOrImportProjectFormTest" selenium test by Ohrimenko1988 · Pull Request #10118 · eclipse-che/che

Ohrimenko1988 · 2018-06-20T14:54:43Z

What does this PR do?

Fix of unexpected fail of "AddOrImportProjectFormTest" selenium test

What issues does this PR fix or reference?

Issue #10111

Release Notes

Docs PR

…lving unexpected tests fails

…nd resolving the reason of the test failing

Ohrimenko1988 · 2018-06-20T14:55:00Z

ci-test

vparfonov · 2018-06-20T15:34:47Z

...m-test/src/test/java/org/eclipse/che/selenium/dashboard/workspaces/NewWorkspacePageTest.java

+  private static final String JDK_SUGGESTION_TITLE = "JDK";
+  private static final String JAVA_SUGGESTION_TITLE = "JAVA";
+  private static final String JAVA_1_8_SUGGESTION_TITLE = "JAVA 1.8";
  private static final String NAME_WITH_ONE_HUNDRED_SYMBOLS =


Actually, not related to your changes, but maybe will be useful for you.
We have utility class for name generation NameGenerator. With it you can generate name with given prefix and length. So for generate workspace name with 100 symbols you can call : NameGenerator.generate("wksp-", 95)

codenvy-ci · 2018-06-20T15:42:58Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10118
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

…tedStacks)' method

… test

…nd change related data

…n the 'Docker' and 'Openshift' infrastructure

Ohrimenko1988 · 2018-06-22T15:28:08Z

ci-test

codenvy-ci · 2018-06-22T20:56:19Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10118
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Ohrimenko1988 · 2018-06-23T13:09:56Z

ci-test

codenvy-ci · 2018-06-23T13:38:24Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10118
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

riuvshin · 2018-06-23T14:02:21Z

ci-test

codenvy-ci · 2018-06-23T19:22:42Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10118
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-06-25T07:53:43Z

.../src/test/java/org/eclipse/che/selenium/dashboard/workspaces/AddOrImportProjectFormTest.java

        EXPECTED_SAMPLES_WITH_DESCRIPTIONS.get(CONSOLE_SAMPLE_NAME),
        EXPECTED_CONSOLE_REPOSITORY_URL);

+    addOrImportForm.clickOnAddOrImportProjectButton();


it would be better to have separate steps divided by empty rows here from the readability point

dmytro-ndp · 2018-06-25T07:56:32Z

...ium-test/src/test/java/org/eclipse/che/selenium/dashboard/workspaces/WorkspacesListTest.java

    return testWorkspaceServiceClient.getAll().size();
  }
+
+  private List<Workspaces.WorkspaceListItem> getUnexpectedWorkspaces(


these methods would be useful for the other tests and so more suitable for the Workspaces page object class

dmytro-ndp · 2018-06-25T14:36:09Z

...ium-test/src/test/java/org/eclipse/che/selenium/dashboard/workspaces/WorkspacesListTest.java

    return testWorkspaceServiceClient.getAll().size();
  }
+
+  private void waitOfOpositeCheckboxState(String workspaceName, boolean currentCheckboxState) {


waitOnOpositeCheckboxState?

dmytro-ndp · 2018-06-25T14:37:17Z

...ium-test/src/test/java/org/eclipse/che/selenium/dashboard/workspaces/WorkspacesListTest.java

+    workspaces.waitWorkspaceCheckboxEnabled(workspaceName);
+  }
+
+  private void clickOnUnexpectedWorkspacesCheckboxes(List<String> expectedWorkspaces) {


This method would be useful for other tests as well. How about moving it into the Workspaces page object as well?

Also, it's not quite clear how Unexpected workspaces differ from ordinary one.

dmytro-ndp · 2018-06-25T14:40:07Z

...ium-test/src/test/java/org/eclipse/che/selenium/dashboard/workspaces/WorkspacesListTest.java

    workspaces.waitWorkspaceCheckboxEnabled(javaWorkspaceName);
    workspaces.waitWorkspaceCheckboxEnabled(blankWorkspaceName);
+
+    // for avoid of failing in the multi-thread mode


it could be useful for reader to know what kind of fail is clickOnUnexpectedWorkspacesCheckboxes is preventing

Ohrimenko1988 · 2018-06-26T13:29:29Z

ci-build

codenvy-ci · 2018-06-26T14:04:43Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4562/

…nium test (eclipse-che#10118)

Ohrimenko1988 added 3 commits June 20, 2018 16:57

Update 'AddOrImportProjectFromTest' and 'WorkspacesListTest' for reso…

e3e46c1

…lving unexpected tests fails

Update 'NewWorkspacePageTest' selenium test for incresing stability a…

16a1544

…nd resolving the reason of the test failing

Merge branch 'master' of https://github.com/eclipse/che into CHE-10111

f67223d

Ohrimenko1988 added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/che-qe labels Jun 20, 2018

Ohrimenko1988 requested review from artaleks9 and dmytro-ndp June 20, 2018 14:54

Ohrimenko1988 requested a review from vparfonov as a code owner June 20, 2018 14:54

vparfonov reviewed Jun 20, 2018

View reviewed changes

Ohrimenko1988 added 2 commits June 21, 2018 14:25

Merge branch 'master' of https://github.com/eclipse/che into CHE-10111

08e26a4

Update stacks list

1112004

vparfonov approved these changes Jun 21, 2018

View reviewed changes

Ohrimenko1988 added 7 commits June 22, 2018 09:44

Merge branch 'master' of https://github.com/eclipse/che into CHE-10111

f195a3d

Merge branch 'master' of https://github.com/eclipse/che into CHE-10111

d7615d1

Update expected stacks list in 'NewWorkspacePageTest' selenium test

764b9a2

Remove debug logging from 'NewWorkspace#waitStacks(List<String> expec…

5f5c521

…tedStacks)' method

Replace inlined constants by enums in 'NewWorkspacePageTest' selenium…

1aeb326

… test

Refactor the 'NewWorkspace#waitStaks' method for working with enum, a…

1371005

…nd change related data

Adopt 'NewWorkspacePageTest' selenium test to the diferent behavior o…

c63456f

…n the 'Docker' and 'Openshift' infrastructure

Ohrimenko1988 added 4 commits June 23, 2018 09:53

Merge branch 'master' of https://github.com/eclipse/che into CHE-10111

12d9b26

Merge branch 'master' of https://github.com/eclipse/che into CHE-10111

461a287

Adopt 'WorkspaceListTest' for running in the multi-thread mode

a45b0f9

Apply workaround for project tab tooltip disappearance

7d6310f

dmytro-ndp reviewed Jun 25, 2018

View reviewed changes

Ohrimenko1988 added 3 commits June 25, 2018 17:07

Add comments according to review

ea41b08

Do changes according to review

be0f362

Merge branch 'master' of https://github.com/eclipse/che into CHE-10111

8481b14

dmytro-ndp reviewed Jun 25, 2018

View reviewed changes

Ohrimenko1988 added 2 commits June 26, 2018 12:45

Merge branch 'master' of https://github.com/eclipse/che into CHE-10111

31572d2

Do changes according to review

b6a5535

dmytro-ndp approved these changes Jun 26, 2018

View reviewed changes

artaleks9 approved these changes Jun 26, 2018

View reviewed changes

Ohrimenko1988 merged commit f51730a into master Jun 26, 2018

Ohrimenko1988 deleted the CHE-10111 branch June 26, 2018 14:17

Ohrimenko1988 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 26, 2018

Ohrimenko1988 mentioned this pull request Jun 26, 2018

Unexpected fail of "AddOrImportProjectFormTest" selenium test #10111

Closed

benoitf added this to the 6.8.0 milestone Jun 26, 2018

hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018

Selenium: Fix of unexpected fail of "AddOrImportProjectFormTest" sele…

20b7336

…nium test (eclipse-che#10118)

Conversation

Ohrimenko1988 commented Jun 20, 2018

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

Uh oh!

Ohrimenko1988 commented Jun 20, 2018

Uh oh!

vparfonov Jun 20, 2018

Choose a reason for hiding this comment

Uh oh!

codenvy-ci commented Jun 20, 2018

Uh oh!

Ohrimenko1988 commented Jun 22, 2018

Uh oh!

codenvy-ci commented Jun 22, 2018

Uh oh!

Ohrimenko1988 commented Jun 23, 2018

Uh oh!

codenvy-ci commented Jun 23, 2018

Uh oh!

riuvshin commented Jun 23, 2018

Uh oh!

codenvy-ci commented Jun 23, 2018

Uh oh!

dmytro-ndp Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

Ohrimenko1988 commented Jun 26, 2018

Uh oh!

codenvy-ci commented Jun 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants