Added secrets into K8s/OS environments#10129
Merged
sleshchenko merged 2 commits intoeclipse-che:masterfrom Jun 22, 2018
Merged
Conversation
sleshchenko
added
the
status/code-review
benoitf
added
the
kind/enhancement
Member
Author
|
ci-test |
davidfestal
approved these changes
Jun 21, 2018
|
ci-test build report: |
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds secrets into K8s/OS environments.
Also, it reworks creation image pull secrets for workspace - previously there was only one image pull secret whole one namespace but it has security issues in multiuser mode and single namespace/project configured. So, now each workspace will use separated secret and it will be removed on workspace stopping.
What issues does this PR fix or reference?
It is needed for #10081 since configuration for JWTProxy will be provided by secrets.
Release Notes
N/A
Docs PR
N/A