Selenium: cover Python language server format feature by selenium test#10149
Merged
SkorikSergey merged 10 commits intomasterfrom Jun 22, 2018
Merged
Selenium: cover Python language server format feature by selenium test#10149SkorikSergey merged 10 commits intomasterfrom
SkorikSergey merged 10 commits intomasterfrom
Conversation
…nFileEditingTest
…nFileEditingTest
…nFileEditingTest
SkorikSergey
added
status/code-review
artaleks9
approved these changes
Jun 22, 2018
dmytro-ndp
reviewed
Jun 22, 2018
| editor.openContextMenuInEditor(); | ||
| editor.clickOnItemInContextMenu(FORMAT); | ||
| editor.waitTextIntoEditor( | ||
| " towers(i-1, middle, finish, start)\n\n\n" + "towers(5, 'X', 'Z', 'Y')\n"); |
Contributor
There was a problem hiding this comment.
" + " looks redundant inside the string.
dmytro-ndp
reviewed
Jun 22, 2018
| editor.typeTextIntoEditor("\n"); | ||
| editor.goToPosition(7, 1); | ||
| editor.goToPosition(18, 53); | ||
| editor.typeTextIntoEditor("\n\n"); |
Contributor
There was a problem hiding this comment.
Looks like these two typeTextIntoEditor commands can be united into the single command:
editor.typeTextIntoEditor("\n\nobject = MyClass()\nprint(object.");
dmytro-ndp
reviewed
Jun 22, 2018
| @@ -132,42 +112,34 @@ public void checkAutocompleteFeature() throws Exception { | |||
| editor.enterAutocompleteProposal("function() "); | |||
| editor.waitTextIntoEditor("print(object.function"); | |||
| editor.typeTextIntoEditor("())"); | |||
Contributor
There was a problem hiding this comment.
What is the propose of typing text "())" into editor if we don't check anything after that?
vparfonov
approved these changes
Jun 22, 2018
dmytro-ndp
reviewed
Jun 22, 2018
| @BeforeClass | ||
| public void setUp() throws Exception { | ||
| URL resource = | ||
| PythonFileEditingTest.this.getClass().getResource("/projects/console-python3-simple"); |
Contributor
There was a problem hiding this comment.
PythonFileEditingTest.this. is redundant here.
dmytro-ndp
reviewed
Jun 22, 2018
| variable = "variable" | ||
|
|
||
| def function(self): | ||
| print("This is a message inside the class.") No newline at end of file |
Contributor
There was a problem hiding this comment.
It would better to add empty line at the end of file.
dmytro-ndp
reviewed
Jun 22, 2018
| print('move disk from ', start, ' to ', finish) | ||
| towers ( i-1, middle, finish, start ) | ||
|
|
||
| towers ( 5, 'X', 'Z', 'Y' ) No newline at end of file |
Contributor
There was a problem hiding this comment.
It would better to add empty line at the end of file.
Contributor
Author
There was a problem hiding this comment.
In this case an empty line will be added as result of Format feature.
dmytro-ndp
approved these changes
Jun 22, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This issue adds checking Python language server format feature to PythonFileEditingTest selenium test.