Fix Routing Strategy Docs#10152
Merged
skabashnyuk merged 1 commit intoeclipse-che:masterfrom Jul 5, 2018
Merged
Conversation
guydc
requested review from
garagatyi,
l0rd,
riuvshin and
sleshchenko
as code owners
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
benoitf
added
status/code-review
ghost
approved these changes
Jun 22, 2018
sleshchenko
approved these changes
Jun 22, 2018
Member
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the quick fix.
garagatyi
approved these changes
Jun 22, 2018
l0rd
approved these changes
Jun 25, 2018
Contributor
|
@guydaichs I think you have forgotten to sign your commits |
Update readme.md Signed-off-by: Guy Daich <guy.daich@sap.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Contributor
Author
|
@l0rd - Sorry. I force-pushed a signed commit now. |
|
Can one of the admins verify this patch? |
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
Fix Routing Strategy Docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Docs
What issues does this PR fix or reference?
#9329 (review)
Release Notes
Docs PR