Skip to content

Selenium: set the GitHub username to lowercase when compared to the value 'Federated Identity'#10157

Merged
artaleks9 merged 1 commit intomasterfrom
che#10156
Jun 23, 2018
Merged

Selenium: set the GitHub username to lowercase when compared to the value 'Federated Identity'#10157
artaleks9 merged 1 commit intomasterfrom
che#10156

Conversation

@artaleks9
Copy link
Copy Markdown
Contributor

@artaleks9 artaleks9 commented Jun 22, 2018 •
edited
Loading

What does this PR do?

  • Correct selenium tests which have comparing the the GitHub username with the value on the Federated Identity page in the Keycloak
  • Set the Git Hub username in the lower case
  • Related selenium tests: ImportWizardFormTest, AuthorizeOnGithubFromPreferencesT

What issues does this PR fix or reference?

#10138, #10156

@artaleks9 artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Jun 22, 2018
@artaleks9 artaleks9 requested a review from vparfonov as a code owner June 22, 2018 14:13
@artaleks9
Copy link
Copy Markdown
Contributor Author

artaleks9 commented Jun 22, 2018

ci-test

@codenvy-ci
Copy link
Copy Markdown

codenvy-ci commented Jun 22, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10157
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9 artaleks9 merged commit ee9e7c3 into master Jun 23, 2018
@artaleks9 artaleks9 deleted the che#10156 branch June 23, 2018 07:35
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 23, 2018
@benoitf benoitf added this to the 6.8.0 milestone Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

+1 more reviewer

@SkorikSergey SkorikSergey SkorikSergey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Milestone

6.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@artaleks9 @codenvy-ci @dmytro-ndp @SkorikSergey @benoitf