Selenium: Create E2E test for checking Hot update feature for wsmaster by Ohrimenko1988 · Pull Request #10176 · eclipse-che/che

Ohrimenko1988 · 2018-06-25T13:32:59Z

What does this PR do?

Create E2E test for checking Hot update feature for wsmaster

What issues does this PR fix or reference?

Issue: #9646

Release Notes

Docs PR

…orkspacesStartStopTest' and 'RolloutUpdateStrategyWithEditorTest' selenium tests

dmytro-ndp · 2018-06-25T13:43:30Z

...st/src/test/java/org/eclipse/che/selenium/hotupdate/RolloutUpdateStrategyWithEditorTest.java

+
+  private void waitRevision(int expectedRevision) {
+    webDriverWaitFactory
+        .get(100)


100 in unclear here. It's better to use dedicated constant to express timeout.

dmytro-ndp · 2018-06-25T13:47:00Z

...st/src/test/java/org/eclipse/che/selenium/hotupdate/RolloutUpdateStrategyWithEditorTest.java

+          + "import java.util.Random;\n"
+          + "\n";
+
+  private static final String EXPECTED_CHANGED_TEXT =


looks like EXPECTED_CHANGED_TEXT = TEXT_FOR_TYPING + EXPECTED_DEFAULT_TEXT
If so, it would be clearer and simpler to defined that constant in such way.

dmytro-ndp · 2018-06-25T13:49:01Z

...st/src/test/java/org/eclipse/che/selenium/hotupdate/RolloutUpdateStrategyWithEditorTest.java

+
+    projectExplorer.quickExpandWithJavaScript();
+
+    projectExplorer.openItemByVisibleNameInExplorer(NAME_OF_CHECKED_CLASS + ".java");


We can avoid duplication if we will have dedicated constant to describe NAME_OF_CHECKED_CLASS_FILE = NAME_OF_CHECKED_CLASS + ".java"

musienko-maxim · 2018-06-25T14:23:08Z

...st/src/test/java/org/eclipse/che/selenium/hotupdate/RolloutUpdateStrategyWithEditorTest.java

+    executeRolloutUpdateCommand();
+
+    // check editor availability during rollout updating
+    Assert.assertEquals(cheTestSystemClient.getStatus(), SystemStatus.RUNNING);


Static import

Ohrimenko1988 · 2018-06-26T09:36:05Z

ci-test

musienko-maxim · 2018-06-26T12:07:50Z

...st/src/test/java/org/eclipse/che/selenium/hotupdate/RolloutUpdateStrategyWithEditorTest.java

+  private static final int TIMEOUT_FOR_ROLLING_UPDATE_FINISH = 100;
+  private static final int RESTORE_IDE_AFTER_REFRESH_TIMEOUT = 10;
+  private static final int EXPECTED_PREFERENCES_RESPONCE_CODE = 200;
+  private static final String PROJECT_NAME = "default-spring-project";


May be we will use all HTTP statuses from single entry point. I propose from this: javax.ws.rs.core.Response.Status.ACCEPTED. In this case we won't need any fields for storing HTTP statuses
WDYT?

Good catch!

Even more - we doesn't need to check response code so as in case of error HttpJsonResponse#request() throws one of the next type of exception: ServerException, UnauthorizedException, ForbiddenException, NotFoundException, ConflictException, BadRequestException.
So, just calling TestUserPreferencesServiceClient#getPreferences() would be enough to check if everything is okay with WS master server.

Totally agree

dmytro-ndp · 2018-06-26T12:52:46Z

@Ohrimenko1988: to run tests regularly on CI we need to divide Rollout strategy tests from RecreateUpdateStrategyTest* to make it possible to run all kind of tests separately by one command: selenium-tests.sh --test=....

The simplest way is to move those tests in dedicated packages:

org.eclipse.che.selenium.hotupdate.recreate
org.eclipse.che.selenium.hotupdate.rollout

ghost · 2018-06-26T12:59:29Z

What is rollout update strategy btw?

Ohrimenko1988 · 2018-06-26T13:02:11Z

@eivantsov Good catch, thank you. Of course "Rolling update".

ghost · 2018-06-26T13:03:17Z

I think it's be nice to refactor a little bit to respect K8S spec :)

dmytro-ndp

fixup looks good

codenvy-ci · 2018-06-26T14:59:23Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10176
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

eclipse-che#10176)

musienko-maxim and others added 22 commits June 13, 2018 14:45

Add sceleton for hot update testing

7a0d212

Merge branch 'master' into CHE-9988

329ef7e

Merge branch 'master' of https://github.com/eclipse/che into CHE-9988

0d3b1b8

add new methods and steps

288bab6

Merge branch 'master' into CHE-9988

fd1221b

Create main steps for 'RolloutUpdate' selenium test

4054956

Merge branch 'master' into CHE-9988

6f56773

merhe changes

98a4952

Merge branch 'master' into CHE-9988

a19227b

Merge branch 'master' of https://github.com/eclipse/che into CHE-9988

cda332e

Merge branch 'CHE-9988' of https://github.com/eclipse/che into CHE-9988

e2a5016

add methods for working with REST API

e0666a1

fix logic errors, add steps

a261067

Merge branch 'master' of https://github.com/eclipse/che into CHE-9988

a1f0b56

Merge branch 'CHE-9988' of https://github.com/eclipse/che into CHE-9988

522a534

Merge branch 'master' of https://github.com/eclipse/che into CHE-9988

97010ea

Add new changes to 'RolloutUpdate' selenium test

14e677e

Merge master and resolve conflict

782071f

Fixup build fail

cf7af42

Delete redundant 'RecreateUpdate' selenium test

0947b7e

Separate 'RolloutUpdate' selenium test to 'RolloutUpdateStrategyWithW…

11f4083

…orkspacesStartStopTest' and 'RolloutUpdateStrategyWithEditorTest' selenium tests

Merge branch 'master' of https://github.com/eclipse/che into CHE-9988

a3cfcad

Ohrimenko1988 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jun 25, 2018

Ohrimenko1988 requested review from dmytro-ndp and musienko-maxim June 25, 2018 13:33

Ohrimenko1988 requested a review from vparfonov as a code owner June 25, 2018 13:33

dmytro-ndp reviewed Jun 25, 2018

View reviewed changes

musienko-maxim reviewed Jun 25, 2018

View reviewed changes

Ohrimenko1988 added 2 commits June 25, 2018 17:55

Do changes according to review

4193099

Do changes according to review

ca6bb99

musienko-maxim approved these changes Jun 25, 2018

View reviewed changes

dmytro-ndp approved these changes Jun 25, 2018

View reviewed changes

Ohrimenko1988 added 2 commits June 26, 2018 09:44

Merge branch 'master' of https://github.com/eclipse/che into CHE-9988

65ffadf

Do changes according to review

32fc87e

Ohrimenko1988 added 2 commits June 26, 2018 13:20

Merge branch 'master' of https://github.com/eclipse/che into CHE-9988

2f6cf07

Do changes according to review

8ad671e

dmytro-ndp approved these changes Jun 26, 2018

View reviewed changes

musienko-maxim reviewed Jun 26, 2018

View reviewed changes

Revert changes from 'TestUserPreferencesServiceClient' class

ec0afe3

Ohrimenko1988 added 4 commits June 26, 2018 16:06

Do changes according to review

c71ae81

Do changes according to review

c82d4cd

Do changes according to review

f77d5e7

Merge branch 'master' of https://github.com/eclipse/che into CHE-9988

f60f99d

dmytro-ndp approved these changes Jun 26, 2018

View reviewed changes

Ohrimenko1988 merged commit ca695ee into master Jun 26, 2018

Ohrimenko1988 deleted the CHE-9988 branch June 26, 2018 13:33

Ohrimenko1988 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 26, 2018

Ohrimenko1988 mentioned this pull request Jun 26, 2018

Create E2E test for checking Hot update feature for wsmaster #9646

Closed

dmytro-ndp mentioned this pull request Jun 26, 2018

Create CI job to test Rolling Workspace Update Strategy #10200

Closed

benoitf added this to the 6.8.0 milestone Jun 26, 2018

hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018

Selenium: Create E2E test for checking Hot update feature for wsmaster (

ec90977

eclipse-che#10176)


		projectExplorer.quickExpandWithJavaScript();

		projectExplorer.openItemByVisibleNameInExplorer(NAME_OF_CHECKED_CLASS + ".java");

Conversation

Ohrimenko1988 commented Jun 25, 2018

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

Uh oh!

dmytro-ndp Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

musienko-maxim Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

Ohrimenko1988 commented Jun 26, 2018

Uh oh!

musienko-maxim Jun 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 26, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Jun 26, 2018

Choose a reason for hiding this comment

Uh oh!

musienko-maxim Jun 26, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp commented Jun 26, 2018

Uh oh!

ghost commented Jun 26, 2018

Uh oh!

Ohrimenko1988 commented Jun 26, 2018

Uh oh!

ghost commented Jun 26, 2018

Uh oh!

dmytro-ndp left a comment

Choose a reason for hiding this comment

Uh oh!

codenvy-ci commented Jun 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dmytro-ndp Jun 25, 2018 •

edited

Loading

musienko-maxim Jun 26, 2018 •

edited

Loading