Fix a bug in the Che GWT maven plugin that prevents RhChe to build with upstream master#10177
Merged
davidfestal merged 1 commit intomasterfrom Jun 26, 2018
Merged
Fix a bug in the Che GWT maven plugin that prevents RhChe to build with upstream master#10177davidfestal merged 1 commit intomasterfrom
master#10177davidfestal merged 1 commit intomasterfrom
Conversation
since the precise version can be a different for the excluded artifact. Signed-off-by: David Festal <dfestal@redhat.com>
|
Can one of the admins verify this patch? |
ibuziuk
approved these changes
Jun 25, 2018
benoitf
added
status/code-review
l0rd
approved these changes
Jun 25, 2018
skabashnyuk
approved these changes
Jun 25, 2018
Contributor
|
ci-test |
|
ci-test build report: |
benoitf
removed
the
status/code-review
SkorikSergey
added a commit
that referenced
this pull request
Oct 25, 2018
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
…th upstream `master` (eclipse-che#10177) It is a bug in the Che GWT maven plugin (in the `ProcessExcludesMojo`) that prevents `rh-che` to build correctly against the Che upstream `master` branch. The fix consists in using the `baseVersion` (i.e. `6.8.0-SNAPSHOT` for example), instead of the precise version (i.e. `6.8.0-20180625.090508-19` for example) when trying to resolve excluded artifacts, since the precise version available in the Maven repositories can be a different between the main artifact and excluded artifacts. Signed-off-by: David Festal <dfestal@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the root cause of the CI build failures that can be found here: https://ci.codenvycorp.com/job/rh-che-ci-master
It is a bug in the Che GWT maven plugin (in the
ProcessExcludesMojo) that preventsrh-cheto build correctly against the Che upstreammasterbranch.The fix consists in using the
baseVersion(i.e.6.8.0-SNAPSHOTfor example), instead of the precise version (i.e.6.8.0-20180625.090508-19for example) when trying to resolve excluded artifacts, since the precise version available in the Maven repositories can be a different between the main artifact and excluded artifacts.What issues does this PR fix or reference?
It fixes CI build failures that can be found here: https://ci.codenvycorp.com/job/rh-che-ci-master