Skip to content

Correct revert unsaved preference changes#10179

Merged
vzhukovs merged 6 commits intomasterfrom
che#9959
Jul 9, 2018
Merged

Correct revert unsaved preference changes#10179
vzhukovs merged 6 commits intomasterfrom
che#9959

Conversation

@vzhukovs
Copy link
Copy Markdown
Contributor

@vzhukovs vzhukovs commented Jun 25, 2018

What does this PR do?

This changes proposal fixes the problem when save button might appeared when refresh button called from preferences window.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

#9959 #10019

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs added kind/bug Outline of a bug - must adhere to the bug report template. team/ide severity/P2 Has a minor but important impact to the usage or development of the system. labels Jun 25, 2018
@vzhukovs vzhukovs added this to the 6.8.0 milestone Jun 25, 2018
@vzhukovs vzhukovs self-assigned this Jun 25, 2018
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 25, 2018
@codenvy-ci
Copy link
Copy Markdown

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10179
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@eclipse-che eclipse-che deleted a comment from codenvy-ci Jul 3, 2018
@eclipse-che eclipse-che deleted a comment from codenvy-ci Jul 3, 2018
@eclipse-che eclipse-che deleted a comment from codenvy-ci Jul 3, 2018
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs
Copy link
Copy Markdown
Contributor Author

vzhukovs commented Jul 3, 2018

ci-build

@vzhukovs
Copy link
Copy Markdown
Contributor Author

vzhukovs commented Jul 3, 2018

ci-test

@eclipse-che eclipse-che deleted a comment from codenvy-ci Jul 3, 2018
@codenvy-ci
Copy link
Copy Markdown

Build # 4563 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4563/ to view the results.

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 3, 2018

ci-test

@codenvy-ci
Copy link
Copy Markdown

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10179
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs requested a review from tolusha as a code owner July 6, 2018 09:01
@vzhukovs
Copy link
Copy Markdown
Contributor Author

vzhukovs commented Jul 6, 2018

ci-test

@codenvy-ci
Copy link
Copy Markdown

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10179
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vzhukovs vzhukovs merged commit f43c8d6 into master Jul 9, 2018
@vzhukovs vzhukovs deleted the che#9959 branch July 9, 2018 09:34
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 9, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
### What does this PR do?
This changes proposal fixes the problem when save button might appeared when refresh button called from preferences window.

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>

### What issues does this PR fix or reference?
eclipse-che#9959 eclipse-che#10019 

#### Release Notes
N/A

#### Docs PR
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants