Make Authorization header value more uniform and use 'Bearer' prefix#10197
Merged
mshaposhnik merged 1 commit intomasterfrom Jun 27, 2018
Merged
Make Authorization header value more uniform and use 'Bearer' prefix#10197mshaposhnik merged 1 commit intomasterfrom
mshaposhnik merged 1 commit intomasterfrom
Conversation
sleshchenko
approved these changes
Jun 26, 2018
mshaposhnik
requested review from
skabashnyuk and
sleshchenko
and removed request for
garagatyi and
vparfonov
benoitf
added
kind/bug
sleshchenko
approved these changes
Jun 26, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds 'Bearer' prefix into
Authenticationheader of all machine-token signed requests.Thats made to unify tokens format with oidc protocol and avoid potential problems with 3rd party authenticators (like jwtproxy or smthn else)
What issues does this PR fix or reference?
Release Notes
N/A
Docs PR
N/A