#10229 Publish all workspace pod events to the machine logs#10228
#10229 Publish all workspace pod events to the machine logs#10228ibuziuk merged 1 commit intoeclipse-che:masterfrom
Conversation
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
ibuziuk
requested review from
amisevsk,
garagatyi,
l0rd and
sleshchenko
and removed request for
garagatyi
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
ibuziuk
added
status/code-review
ibuziuk
changed the title
benoitf
left a comment
benoitf
left a comment
There was a problem hiding this comment.
IMHO it is very nice to grab other events
|
ci-test |
amisevsk
left a comment
amisevsk
left a comment
There was a problem hiding this comment.
Good to have, especially with recent PVC issues.
|
ci-test build report: |
benoitf
removed
the
status/code-review
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
Please take my inlined comments
| machines.getMachines(getContext().getIdentity()).entrySet()) { | ||
| final KubernetesMachineImpl machine = entry.getValue(); | ||
| if (machine.getPodName().equals(podName) | ||
| && machine.getContainerName().equals(containerName)) { |
There was a problem hiding this comment.
@ibuziuk Looks like in the case when there are two containers in one pod, containers related events will be published in both machines, something like the following example in case OpenShift Sql stack:
pulling image `eclipse-che/ubuntu`
pulling image `eclipse-che/ubuntu`
Successfully pulled image `eclipse-che/mysql`
Successfully pulled image `eclipse-che/mysql`
Created container
Created container
Started container
Started container
Is it true or I missed something? If it's true let's filter events by container name if it is not empty.
There was a problem hiding this comment.
Another fix that I think is needed for multi-container workspace is removing return statement here since two or more machines may be related to the same pod and it's OK to duplicate logs in such cases, otherwise, the only first machine will have logs. WDYT?
There was a problem hiding this comment.
@sleshchenko yeah, you are right. I missed the part with multi-container workspaces 👍
7 participants
What does this PR do?
Publish all workspace pod events to the machine logs (not only container events).
This would enrich logs automatically with "Scheduled" & "Successful Mount Volume"
What issues does this PR fix or reference?
#10229
N/A
Release Notes
N/A
Docs PR
N/A