Skip to content

Fix logic error in CSharpFileEditingTest#10239

Merged
musienko-maxim merged 2 commits intomasterfrom
quick_fix_for_Csharp
Jul 5, 2018
Merged

Fix logic error in CSharpFileEditingTest#10239
musienko-maxim merged 2 commits intomasterfrom
quick_fix_for_Csharp

Conversation

@musienko-maxim
Copy link
Copy Markdown
Contributor

@musienko-maxim musienko-maxim commented Jul 2, 2018

What does this PR do?

  • Fix logic error in the test. In the user story after fixing errors - we should wait disappearing of error marker. But we wait disappearance of info marker.

@musienko-maxim
Copy link
Copy Markdown
Contributor Author

ci-build

@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jul 2, 2018
@musienko-maxim
Copy link
Copy Markdown
Contributor Author

ci-build

@codenvy-ci
Copy link
Copy Markdown

Build # 4564 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4564/ to view the results.

@musienko-maxim
Copy link
Copy Markdown
Contributor Author

ci-build

1 similar comment
@musienko-maxim
Copy link
Copy Markdown
Contributor Author

ci-build

@musienko-maxim musienko-maxim merged commit d767fd4 into master Jul 5, 2018
@musienko-maxim musienko-maxim deleted the quick_fix_for_Csharp branch July 5, 2018 07:22
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 5, 2018
@benoitf benoitf added this to the 6.8.0 milestone Jul 5, 2018
@codenvy-ci
Copy link
Copy Markdown

Build # 4570 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4570/ to view the results.

hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants