Change the loading flow by always wait the runtime before open IDE#10263
Merged
ashumilova merged 2 commits intomasterfrom Jul 9, 2018
Merged
Change the loading flow by always wait the runtime before open IDE#10263ashumilova merged 2 commits intomasterfrom
ashumilova merged 2 commits intomasterfrom
Conversation
ashumilova
added
kind/bug
benoitf
approved these changes
Jul 4, 2018
Contributor
benoitf
left a comment
benoitf
left a comment
There was a problem hiding this comment.
@ashumilova do we have all workspace events displayed on the loader ?
Contributor
Author
|
@benoitf We are tracking only 2: workspace status event (for further actions) and environment output - for displaying logs. |
vitaliy-guliy
approved these changes
Jul 4, 2018
Contributor
|
@ashumilova so it will include #10228 events as well ? |
evidolob
approved these changes
Jul 9, 2018
…d add error handling Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
… IDE and add error handling
benoitf
removed
the
status/code-review
Contributor
Author
|
@benoitf perhaps it should, if are published in machine/log channel. |
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
…clipse-che#10263) * Change the loading flow by always wait the runtime before open IDE and add error handling Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
skabashnyuk
pushed a commit
to skabashnyuk/che
that referenced
this pull request
Mar 11, 2020
…clipse-che#10263) * Change the loading flow by always wait the runtime before open IDE and add error handling Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anna Shumilova ashumilo@redhat.com
What does this PR do?
Changes the flow of the workspace loading application:
What issues does this PR fix or reference?
#9870
Release Notes
Docs PR