Refactored external servers exposition in K8s/OS infrastructures#10266
Merged
sleshchenko merged 5 commits intoeclipse-che:masterfrom Jul 5, 2018
Merged
Refactored external servers exposition in K8s/OS infrastructures#10266sleshchenko merged 5 commits intoeclipse-che:masterfrom
sleshchenko merged 5 commits intoeclipse-che:masterfrom
Conversation
sleshchenko
added
kind/enhancement
garagatyi
approved these changes
Jul 4, 2018
garagatyi
left a comment
garagatyi
left a comment
There was a problem hiding this comment.
Looks good!
BTW each significant change we do in this area I realize that had to do the code simpler and cleaner in the first place.
But thank you for moving the code in the direction of simplicity!
Member
Author
|
ci-test |
|
ci-test build report: |
sleshchenko
force-pushed
the
k8sServerExposingRefactor
branch
from
423de2d to
59b4301
Compare
20 tasks
Contributor
|
QE team did not find new regressions after selenium session. |
musienko-maxim
approved these changes
Jul 5, 2018
…by one Previously expose server strategy had to match servers with services port, but sometimes it is impossible like in case of JWT proxy. Because in this case, server config contains port that is different to service port. Like `wsagent` server is exposed on 4401 original service port, but it will be publicly accessible via 4911 (random one) JWTProxy service port.
sleshchenko
force-pushed
the
k8sServerExposingRefactor
branch
from
59b4301 to
68424c9
Compare
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors external servers exposition in K8s/OS infrastructures:
moves external servers related classes to a separated package;
fixes java doc in OpenShiftExternalServerExposer;
makes ServerServiceBuilder non-internal class to make it possible to reuse it;
refactors external server exposer strategy to expose service port one by one;
Previously expose server strategy had to match servers with services port, but sometimes it is impossible like in case of JWT proxy. Because in this case, server config contains port that is different to service port. Like
wsagentserver is exposed on 4401 original service port, but it will be publicly accessible via 4911 (random one) JWTProxy service port.fixes and improve tests
What issues does this PR fix or reference?
It is changes needed for #10081.
Separated changes from #10252 to make review easier.
Release Notes
N/A
Docs PR
N/A