Fix namespace for deployment under OCP user account#10267
Merged
dmytro-ndp merged 2 commits intomasterfrom Jul 4, 2018
Merged
Conversation
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
benoitf
added
status/code-review
sleshchenko
approved these changes
Jul 4, 2018
|
|
||
| ReplicaSet replicaSet = | ||
| clientFactory.create(workspaceId).extensions().replicaSets().withName(replicaSetName).get(); | ||
| clientFactory.create(workspaceId).extensions().replicaSets().inNamespace(namespace).withName(replicaSetName).get(); |
Member
There was a problem hiding this comment.
This line looks too long. Please make sure that it is well formatted (mvn fmt:format)
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes namespace of Kubernetes client which is used to operate with OCP deployments.
(Fixup was kindly proposed by @sleshchenko.)
What issues does this PR fix or reference?
#10265