Selenium: Fix reason of failing the "RollingUpdateStrategyWithEditorTest" selenium test#10269
Merged
Ohrimenko1988 merged 9 commits intomasterfrom Jul 5, 2018
Merged
Selenium: Fix reason of failing the "RollingUpdateStrategyWithEditorTest" selenium test#10269Ohrimenko1988 merged 9 commits intomasterfrom
Ohrimenko1988 merged 9 commits intomasterfrom
Conversation
…WithWorkspacesStartStopTest' and 'RollingUpdateStrategyWithEditorTest' selenium tests
Ohrimenko1988
added
kind/bug
Contributor
Author
|
ci-build |
dmytro-ndp
reviewed
Jul 4, 2018
| import org.openqa.selenium.support.ui.ExpectedCondition; | ||
|
|
||
| @Singleton | ||
| public class HotUpdateUtil { |
Contributor
There was a problem hiding this comment.
It would be grateful to have short info about proposal of the class in the docs
dmytro-ndp
reviewed
Jul 4, 2018
| private final TestUserPreferencesServiceClient testUserPreferencesServiceClient; | ||
|
|
||
| @Inject | ||
| HotUpdateUtil( |
Contributor
There was a problem hiding this comment.
It's mostly about Rolling update, so the name HotRollingUpdateUtil better describes class propose, IMHO
Contributor
Author
There was a problem hiding this comment.
It is also used in the recreate test, and all methods do not have a dependency to update strategy.
dmytro-ndp
reviewed
Jul 4, 2018
| @@ -63,7 +51,7 @@ public void createMavenArchetypeStartProjectByWizard() throws Exception { | |||
| workspaces.waitWorkspaceStatus(workspaceForStarting.getName(), Workspaces.Status.STOPPED); | |||
|
|
|||
| // execute rolling update command | |||
Contributor
There was a problem hiding this comment.
You may mean // execute rollout update command.
Contributor
Author
There was a problem hiding this comment.
Even more, I think "hotUpdateUtil.executeMasterPodUpdateCommand();" definitely clear command so comment is redundant here.
dmytro-ndp
approved these changes
Jul 5, 2018
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4569/ |
dmytro-ndp
approved these changes
Jul 5, 2018
musienko-maxim
approved these changes
Jul 5, 2018
benoitf
removed
the
status/code-review
hbhargav
pushed a commit
to hbhargav/che
that referenced
this pull request
Dec 5, 2018
…est" selenium test (eclipse-che#10269)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix reason of failing the "RollingUpdateStrategyWithEditorTest" selenium test
What issues does this PR fix or reference?
Issue: #10251
Release Notes
Docs PR