Skip to content

Selenium: cover workspace creation from Ubuntu stacks by selenium tests#10271

Merged
SkorikSergey merged 11 commits intomasterfrom
createWorkspaceFromUbuntuStacks
Jul 11, 2018
Merged

Selenium: cover workspace creation from Ubuntu stacks by selenium tests#10271
SkorikSergey merged 11 commits intomasterfrom
createWorkspaceFromUbuntuStacks

Conversation

@SkorikSergey
Copy link
Copy Markdown
Contributor

@SkorikSergey SkorikSergey commented Jul 4, 2018 •
edited
Loading

What does this PR do?

This PR creates selenium tests that cover workspace creation from next Ubuntu stacks:

  • .NET
  • C++
  • Eclipse Che
  • Go
  • Java Theia (docker)
  • Java Theia (openshift)
  • Kotlin
  • Node
  • PHP
  • Rails

What issues does this PR fix or reference?

#10270, #10050

Release Notes

Docs PR

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Jul 4, 2018
@SkorikSergey SkorikSergey requested a review from vparfonov as a code owner July 4, 2018 14:56
@SkorikSergey
Copy link
Copy Markdown
Contributor Author

SkorikSergey commented Jul 4, 2018

ci-test

@codenvy-ci
Copy link
Copy Markdown

codenvy-ci commented Jul 4, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10271
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Copy Markdown
Contributor Author

SkorikSergey commented Jul 5, 2018

ci-test

@codenvy-ci
Copy link
Copy Markdown

codenvy-ci commented Jul 5, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10271
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Jul 10, 2018
dmytro-ndp
dmytro-ndp reviewed Jul 10, 2018
View reviewed changes
...test/src/test/java/org/eclipse/che/selenium/stack/CreateWorkspaceFromJavaMySqlStackTest.java
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

/** @author Aleksandr Shmaraev */
Copy link
Copy Markdown
Contributor

@dmytro-ndp dmytro-ndp Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Aleksandr Shmaraev the real author of the test?

Copy link
Copy Markdown
Contributor Author

@SkorikSergey SkorikSergey Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I renamed WorkingWithJavaMySqlStackTest test to CreateWorkspaceFromJavaMySqlStackTest.

dmytro-ndp
dmytro-ndp reviewed Jul 10, 2018
View reviewed changes
...est/src/test/java/org/eclipse/che/selenium/stack/CreateWorkspaceFromEclipseCheStackTest.java Outdated

@BeforeClass
public void setUp() {

Copy link
Copy Markdown
Contributor

@dmytro-ndp dmytro-ndp Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line looks redundant here

dmytro-ndp
dmytro-ndp reviewed Jul 10, 2018
View reviewed changes
...est/src/test/java/org/eclipse/che/selenium/stack/CreateWorkspaceFromEclipseCheStackTest.java

@Test(priority = 1)
public void checkConsoleJavaSimpleProjectCommands() {
consoles.executeCommandFromProjectExplorer(
Copy link
Copy Markdown
Contributor

@dmytro-ndp dmytro-ndp Jul 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not enough to check Eclipse Che stack with Java Simple Project. This stack is dedicated to develop something related to Eclipse Che project including Eclipse Che extensions, and Eclipse Che project itself, and there is separate issue for this staff #10107, which becomes partly resolved.

@SkorikSergey
Copy link
Copy Markdown
Contributor Author

SkorikSergey commented Jul 11, 2018

ci-build

@SkorikSergey
Copy link
Copy Markdown
Contributor Author

SkorikSergey commented Jul 11, 2018

ci-build

@SkorikSergey SkorikSergey merged commit b8bdc29 into master Jul 11, 2018
@SkorikSergey SkorikSergey deleted the createWorkspaceFromUbuntuStacks branch July 11, 2018 07:49
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 11, 2018
@benoitf benoitf added this to the 6.9.0 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@artaleks9 artaleks9 artaleks9 approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

No one assigned

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Milestone

6.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@SkorikSergey @codenvy-ci @dmytro-ndp @artaleks9 @benoitf