Skip to content

Selenium: Implement usecase which covers opening a file from libraries after refreshing#10320

Merged
Ohrimenko1988 merged 6 commits intomasterfrom
selen-implement-9992
Jul 9, 2018
Merged

Selenium: Implement usecase which covers opening a file from libraries after refreshing#10320
Ohrimenko1988 merged 6 commits intomasterfrom
selen-implement-9992

Conversation

@Ohrimenko1988
Copy link
Copy Markdown
Contributor

What does this PR do?

Implement usecase which covers opening a file from libraries after refreshing

What issues does this PR fix or reference?

Issue: #9992

Release Notes

Docs PR

@Ohrimenko1988 Ohrimenko1988 added kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Jul 6, 2018
@Ohrimenko1988 Ohrimenko1988 requested a review from vparfonov as a code owner July 6, 2018 13:32
}

private void openFileFromExternalLibraryAndCheckDisplayedText() {
projectExplorer.waitVisibilityByName("README.md");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could shorten a code if we will have the method:
projectExplorer.waitVisibilityByName(String... names)
projectExplorer.openItemByVisibleNameInExplorer(String... names)

@dmytro-ndp
Copy link
Copy Markdown
Contributor

Don't forget to add the test OpenExternalLibraryFileAfterRefreshTest to the CheSuite.xml.

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 6, 2018

/**
* Invokes the {@link ProjectExplorer#openItemByVisibleNameInExplorer(String)} method for each
* specified {@code name}.
Copy link
Copy Markdown
Contributor

@dmytro-ndp dmytro-ndp Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may mean {@code names}.

@Ohrimenko1988 Ohrimenko1988 merged commit 59c1fa1 into master Jul 9, 2018
@Ohrimenko1988 Ohrimenko1988 deleted the selen-implement-9992 branch July 9, 2018 06:58
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 9, 2018
@benoitf benoitf added this to the 6.8.0 milestone Jul 9, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants