Selenium: Create selenium test for covering issue #9620 "In case ws-agent stopped unexpectedly all editors should become in readonly mode or close them"#10354
Conversation
Ohrimenko1988
added
status/code-review
|
|
||
| public class EditorBehaviorDuringUnexpectedWsAgentStopTest { | ||
| private static final String PROJECT_NAME = NameGenerator.generate("WsAgentTest", 4); | ||
| private static final String FIND_CONTAINER_ID_COMMAND_TEMPLATE = |
There was a problem hiding this comment.
Did you check it with Eclipse Che on Docker?
|
It's interested to know why it was decided not to use simpler method of stopping WS agent from terminal which was used in test CheckRestoringWorkspaceAfterStoppingWsAgentProcessTest.java. Also it's not quite clear why the test "CheckRestoringWorkspaceAfterStoppingWsAgentProcessTest.java" was removed because looks like it checked different use case. |
| toastLoader.clickOnToastLoaderButton("Restart"); | ||
| toastLoader.waitExpectedTextInToastLoader("Starting workspace runtime..."); | ||
| waitWorkspaceRunningStatus(); | ||
| goToFileAndCheckText(); |
There was a problem hiding this comment.
IMHO it may be reasonable to check that editor switched from read-only to normal mode after the workspace had been restored.
|
I has just realized that |
|
Another advantage of stopping the WS agent by executing the command from the terminal inside the IDE is that it works if the product is run at the remote server compare to selenium tests, whereas stopping by executing the command by command local Docker CLI doesn't work. |
|
ci-test |
|
ci-test build report: |
benoitf
removed
the
status/code-review
5 participants
What does this PR do?
Create selenium test for covering issue #9620 "In case ws-agent stopped unexpectedly all editors should become in readonly mode or close them".
What issues does this PR fix or reference?
Issue: #9950
Release Notes
Docs PR