Skip to content

set default k8s namespace to che#10366

Merged
riuvshin merged 6 commits intomasterfrom
k8s_unique
Jul 10, 2018
Merged

set default k8s namespace to che#10366
riuvshin merged 6 commits intomasterfrom
k8s_unique

Conversation

@riuvshin
Copy link
Copy Markdown
Contributor

set default CHE_INFRA_KUBERNETES_NAMESPACE to che

@riuvshin riuvshin self-assigned this Jul 10, 2018
@riuvshin riuvshin requested a review from a user July 10, 2018 15:15
@riuvshin riuvshin changed the title K8s unique set default k8s namespace to che Jul 10, 2018
@riuvshin riuvshin merged commit 19ecb7d into master Jul 10, 2018
@riuvshin riuvshin deleted the k8s_unique branch July 10, 2018 15:31
gitHubClientID: ""
gitHubClientSecret: ""
pvcClaim: "1Gi"
cheInfraKubernetesNamespace: ""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to name it something like cheWorkspacesNamespace from helm chart perspective

@ghost
Copy link
Copy Markdown

ghost commented Jul 11, 2018

@sleshchenko maybe. The name is more self explaining

@sleshchenko
Copy link
Copy Markdown
Member

@riuvshin Could you prepare a PR if it makes sense for you?

@benoitf benoitf added this to the 6.9.0 milestone Jul 11, 2018
@qianlei90
Copy link
Copy Markdown

What's the difference between line 34 and line 53? We already have cheNamespace in values.

@sleshchenko
Copy link
Copy Markdown
Member

@qianlei90 Thanks for pointing.
Values.global.cheNamespace is a namespace where Che objects should be created
Values.global.cheInfraKubernetesNamespace is a namespace where workspace related objects should be created
But definitly CHE_INFRA_KUBERNETES_NAMESPACE env var should be set once. @riuvshin Please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants