Conversation
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
added
kind/bug
Contributor
Author
|
ci-build |
Contributor
Author
|
ci-test |
benoitf
added
the
status/code-review
Contributor
Author
|
ci-build |
vparfonov
approved these changes
Jul 11, 2018
Contributor
|
ci-test build report: |
dkulieshov
approved these changes
Jul 12, 2018
musienko-maxim
approved these changes
Jul 12, 2018
vzhukovs
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes proposal updates regex for c-based file extensions which opens with language server in editor. The problem was that we have special naming for the command items: path is
/commands/{goal}/{name}and display name is{name}.che_command_internaland it conflicted withclangdlanguage server because it provides the regex for those file types:.*\.(c|h|cc|hh|cpp|hpp|cxx|hxx|C|H|CC|HH|CPP|HPP|CXX|HXX). Adding$to the end of the regex fixed problem, now command item successfully open in command editor.Check regex online: https://regexr.com/3s9lv
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
What issues does this PR fix or reference?
#10285
Release Notes
N/A
Docs PR
N/A