Skip to content

Fixed binding of jwt proxy secure servers for Che on K8s/OS#10407

Merged
sleshchenko merged 1 commit intoeclipse-che:masterfrom
sleshchenko:secureServersBindingsFix
Jul 13, 2018
Merged

Fixed binding of jwt proxy secure servers for Che on K8s/OS#10407
sleshchenko merged 1 commit intoeclipse-che:masterfrom
sleshchenko:secureServersBindingsFix

Conversation

@sleshchenko
Copy link
Copy Markdown
Member

What does this PR do?

Single-user Che doesn't have a binding for SignatureKeyManager while JwtProxySecureSeverExposerFactory injects it. So, it is needed to bind JwtProxySecureSeverExposerFactory only when Che is configured as Multi-user.

What issues does this PR fix or reference?

Related to #10252

Release Notes

N/A

Docs PR

N/A

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jul 13, 2018
@sleshchenko sleshchenko self-assigned this Jul 13, 2018
@sleshchenko sleshchenko changed the title Fix binding of jwt proxy secure servers for Che on K8s/OS Fixed binding of jwt proxy secure servers for Che on K8s/OS Jul 13, 2018
@sleshchenko sleshchenko merged commit 798c4f4 into eclipse-che:master Jul 13, 2018
@sleshchenko sleshchenko deleted the secureServersBindingsFix branch July 13, 2018 06:15
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 13, 2018
@benoitf benoitf added this to the 6.9.0 milestone Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants