Skip to content

Fix selenium tests#10418

Merged
tolusha merged 2 commits into5730_java_ls_pocfrom
SeleniumTestFix
Jul 16, 2018
Merged

Fix selenium tests#10418
tolusha merged 2 commits into5730_java_ls_pocfrom
SeleniumTestFix

Conversation

@tolusha
Copy link
Copy Markdown
Contributor

@tolusha tolusha commented Jul 13, 2018

What does this PR do?

  • create debug location with an URI instead of FQN

What issues does this PR fix or reference?

#9591

@tolusha tolusha self-assigned this Jul 13, 2018
@tolusha tolusha requested review from svor and tsmaeder July 13, 2018 13:10
@tolusha tolusha mentioned this pull request Jul 13, 2018
Closed
9 tasks
@benoitf benoitf added target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Jul 13, 2018
@tolusha tolusha mentioned this pull request Jul 16, 2018
Closed
tsmaeder
tsmaeder approved these changes Jul 16, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

...main/java/org/eclipse/che/plugin/java/languageserver/JavaLanguageServerExtensionService.java
} else {
return new LocationImpl(
l.getRight().getFqn(), lineNumber, true, l.getRight().getLibId(), null);
return new LocationImpl(removePrefixUri(l), lineNumber, null);
Copy link
Copy Markdown
Contributor

@tsmaeder tsmaeder Jul 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can call "removePrefixURI" on any uri, it's a no-op for uri's that do not start with the workspace location

@tolusha
Fix selenium tests
19f7a5c 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha
Fix up
f5834b0 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha merged commit 91839a0 into 5730_java_ls_poc Jul 16, 2018
@tolusha tolusha deleted the SeleniumTestFix branch July 16, 2018 09:32
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 16, 2018
tsmaeder pushed a commit that referenced this pull request Jul 27, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
91ba070 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha added a commit that referenced this pull request Aug 7, 2018
@tolusha
Fix selenium tests (#10418)
b74da5d 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Aug 22, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
4ea2c42 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Aug 29, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
572422d 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha added a commit that referenced this pull request Sep 5, 2018
@tolusha
Fix selenium tests (#10418)
a761acd 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Sep 13, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
810a079 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Sep 20, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
097b5b6 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Sep 26, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
84d280e 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 1, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
2f33261 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 5, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
eac37cd 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 12, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
fb95660 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 16, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
c591449 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
cd49354 
* Fix selenium tests

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>

* Fix up

Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
bfb1cef 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
c21da5f 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
c106f55 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
@tolusha @tsmaeder
Fix selenium tests (#10418)
c910038 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svor svor svor approved these changes

@tsmaeder tsmaeder tsmaeder approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@tolusha tolusha

Labels

kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tolusha @svor @tsmaeder @benoitf