Open folder in terminal by vparfonov · Pull Request #10422 · eclipse-che/che

vparfonov · 2018-07-15T07:39:43Z

What does this PR do?

Provide ability to open selected folder in the terminal

What issues does this PR fix or reference?

#10356

Release Notes

Docs PR

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

vparfonov · 2018-07-15T07:40:27Z

ci-test

riuvshin · 2018-07-15T07:50:36Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10422
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

vparfonov · 2018-07-16T06:01:24Z

ci-test

riuvshin · 2018-07-16T06:30:52Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10422
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

vparfonov · 2018-07-16T09:21:43Z

ci-test

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

gazarenkov · 2018-07-16T13:46:29Z

ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/processes/OpenInTerminalAction.java

+
+/**
+ * Action to open new terminal and navigate to selected directory.
+ *


Could you please give some more tech details in the comment.
It will open the terminal window with "cd .." command?

gazarenkov · 2018-07-16T13:50:31Z

ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/terminal/TerminalPresenter.java

@@ -92,7 +92,7 @@ public TerminalPresenter(
   * Connects to special WebSocket which allows get information from terminal on server side. The
   * terminal is initialized only when the method is called the first time.
   */


Could you please add some information about "options" parameter?

gazarenkov · 2018-07-16T13:51:32Z

ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/terminal/TerminalOptionsJso.java

        }
    }-*/;

  public final native TerminalOptionsJso withFocusOnOpen(boolean focusOnOpen) /*-{


Add javadoc please

gazarenkov · 2018-07-16T13:51:48Z

ide/che-core-ide-app/src/main/java/org/eclipse/che/ide/terminal/TerminalOptionsJso.java

        return this;
    }-*/;
+
+  public final native TerminalOptionsJso withCommand(String command) /*-{


Add javadoc please

riuvshin · 2018-07-16T14:39:20Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10422
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

vparfonov · 2018-07-16T15:29:30Z

ci-test

riuvshin · 2018-07-16T20:43:43Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10422
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

vparfonov · 2018-07-17T06:55:15Z

ci-test

riuvshin · 2018-07-17T12:15:37Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10422
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

vparfonov · 2018-07-17T13:13:12Z

ci-test

Ohrimenko1988 · 2018-07-17T13:40:25Z

...e-selenium-test/src/test/java/org/eclipse/che/selenium/miscellaneous/OpenInTerminalTest.java

+  private static final String PATH_TO_EXPAND = "/src/main/java";
+  private static final String FILE = "/README.md";
+
+  @SuppressWarnings("unused")


You can omit the"@SuppressWarnings("unused")"

Ohrimenko1988 · 2018-07-17T13:44:10Z

...e-selenium-test/src/test/java/org/eclipse/che/selenium/miscellaneous/OpenInTerminalTest.java

+    projectExplorer.waitContextMenu();
+    projectExplorer.clickOnItemInContextMenu(OPEN_IN_TERMINAL);
+    terminal.waitNumberTerminalTab(2);
+    String terminalWorkDir = terminal.getVisibleTextFromTerminal();


You can replace the next rows:

String terminalWorkDir = terminal.getVisibleTextFromTerminal(); Assert.assertTrue(terminalWorkDir.trim().endsWith(PROJECT_NAME + "$"));

with:

terminal.waitExpectedTextIntoTerminal(PROJECT_NAME + "$");

Ohrimenko1988 · 2018-07-17T13:50:05Z

...e-selenium-test/src/test/java/org/eclipse/che/selenium/miscellaneous/OpenInTerminalTest.java

+    projectExplorer.clickOnItemInContextMenu(OPEN_IN_TERMINAL);
+    terminal.waitNumberTerminalTab(2);
+    String terminalWorkDir = terminal.getVisibleTextFromTerminal();
+    Assert.assertTrue(terminalWorkDir.trim().endsWith(PROJECT_NAME + PATH_TO_EXPAND + "$"));


Similar to https://github.com/eclipse/che/pull/10422/files#r203026639

Ohrimenko1988 · 2018-07-17T13:50:42Z

...e-selenium-test/src/test/java/org/eclipse/che/selenium/miscellaneous/OpenInTerminalTest.java

+    projectExplorer.clickOnItemInContextMenu(OPEN_IN_TERMINAL);
+    terminal.waitNumberTerminalTab(3);
+    terminalWorkDir = terminal.getVisibleTextFromTerminal();
+    Assert.assertTrue(terminalWorkDir.trim().endsWith(PROJECT_NAME + "$"));


Similar to https://github.com/eclipse/che/pull/10422/files#r203026639

Ohrimenko1988 · 2018-07-17T13:51:19Z

...e-selenium-test/src/test/java/org/eclipse/che/selenium/miscellaneous/OpenInTerminalTest.java

+    seleniumWebDriverHelper.sendKeys(Keys.chord(ALT, SHIFT, F12));
+    terminal.waitNumberTerminalTab(2);
+    String terminalWorkDir = terminal.getVisibleTextFromTerminal();
+    Assert.assertTrue(terminalWorkDir.trim().endsWith(PROJECT_NAME + "$"));


Similar to https://github.com/eclipse/che/pull/10422/files#r203026639

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

vparfonov · 2018-07-17T16:51:32Z

ci-test

riuvshin · 2018-07-17T22:13:53Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10422
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

artaleks9 · 2018-07-18T09:17:11Z

Selenium tests execution on Eclipse Che Multiuser on OCP
(https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/488/)
doesn't show any regression against this Pull Request.

vparfonov added 2 commits July 15, 2018 10:35

Add ability to open selected folder in terminal

f132201

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

Add action in context menu

35eb889

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Jul 15, 2018

vparfonov changed the title ~~Goto terminal~~ Open folder in terminal Jul 15, 2018

Fix formatting

f27d81d

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

Remove not needed file

bd4ca65

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

Code cleanup

183747a

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

gazarenkov reviewed Jul 16, 2018

View reviewed changes

Add javadocs

53ed94a

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

Add test to the suite

ee06fc0

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

Add hotkeys and test

f9f8f88

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

vparfonov requested review from Ohrimenko1988, RomanNikitenko and dkulieshov July 17, 2018 13:12

dkulieshov approved these changes Jul 17, 2018

View reviewed changes

Ohrimenko1988 reviewed Jul 17, 2018

View reviewed changes

vkuznyetsov mentioned this pull request Jul 17, 2018

QE-2018-07-31 (Sprint: 152) #10311

Closed

39 tasks

Ohrimenko1988 reviewed Jul 17, 2018

View reviewed changes

code clean up

cbfad66

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

RomanNikitenko approved these changes Jul 17, 2018

View reviewed changes

code clean up

da3b4ee

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>

Ohrimenko1988 approved these changes Jul 18, 2018

View reviewed changes

vparfonov merged commit 050f4e2 into master Jul 18, 2018

vparfonov deleted the goto-terminal branch July 18, 2018 11:01

vparfonov added this to the 6.9.0 milestone Jul 18, 2018

vparfonov added the team/ide label Jul 18, 2018

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 18, 2018

Conversation

vparfonov commented Jul 15, 2018

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

Uh oh!

vparfonov commented Jul 15, 2018

Uh oh!

riuvshin commented Jul 15, 2018

Uh oh!

vparfonov commented Jul 16, 2018

Uh oh!

riuvshin commented Jul 16, 2018

Uh oh!

vparfonov commented Jul 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

riuvshin commented Jul 16, 2018

Uh oh!

vparfonov commented Jul 16, 2018

Uh oh!

riuvshin commented Jul 16, 2018

Uh oh!

vparfonov commented Jul 17, 2018

Uh oh!

riuvshin commented Jul 17, 2018

Uh oh!

vparfonov commented Jul 17, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vparfonov commented Jul 17, 2018

Uh oh!

riuvshin commented Jul 17, 2018

Uh oh!

artaleks9 commented Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

artaleks9 commented Jul 18, 2018 •

edited

Loading