Skip to content

Update set of existing key-bindings#10426

Merged
svor merged 2 commits into5730_java_ls_pocfrom
che-10424
Jul 16, 2018
Merged

Update set of existing key-bindings#10426
svor merged 2 commits into5730_java_ls_pocfrom
che-10424

Conversation

@svor
Copy link
Copy Markdown
Contributor

@svor svor commented Jul 16, 2018

What does this PR do?

Fixes a test which checks set of key bindings.
Instead of Open editor for selected item we have Find Definition
Instead of Shows all parameters which constructor or method can accept we have Signature Help

What issues does this PR fix or reference?

#10424

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. team/languages labels Jul 16, 2018
@svor svor self-assigned this Jul 16, 2018
@svor svor requested review from tolusha and tsmaeder July 16, 2018 08:09
@svor svor requested a review from vparfonov as a code owner July 16, 2018 08:09
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Copy link
Copy Markdown
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svor svor merged commit 6c08ff9 into 5730_java_ls_poc Jul 16, 2018
@svor svor deleted the che-10424 branch July 16, 2018 09:24
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 16, 2018
tsmaeder pushed a commit that referenced this pull request Jul 27, 2018
tolusha pushed a commit that referenced this pull request Aug 7, 2018
tsmaeder pushed a commit that referenced this pull request Aug 22, 2018
tsmaeder pushed a commit that referenced this pull request Aug 29, 2018
tolusha pushed a commit that referenced this pull request Sep 5, 2018
tsmaeder pushed a commit that referenced this pull request Sep 13, 2018
tsmaeder pushed a commit that referenced this pull request Sep 20, 2018
tsmaeder pushed a commit that referenced this pull request Sep 26, 2018
tsmaeder pushed a commit that referenced this pull request Oct 1, 2018
tsmaeder pushed a commit that referenced this pull request Oct 5, 2018
tsmaeder pushed a commit that referenced this pull request Oct 12, 2018
tsmaeder pushed a commit that referenced this pull request Oct 16, 2018
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
tsmaeder pushed a commit that referenced this pull request Oct 17, 2018
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants