Small fixups for git package#10432
Merged
tolusha merged 1 commit into5730_java_ls_pocfrom Jul 16, 2018
Merged
Conversation
benoitf
added
kind/task
tsmaeder
reviewed
Jul 16, 2018
| testProjectServiceClient.importProject( | ||
| ws.getId(), Paths.get(resource.toURI()), PROJECT_NAME, ProjectTemplates.MAVEN_SPRING); | ||
| ide.open(ws); | ||
| consoles.waitJDTLSProjectResolveFinishedMessage(PROJECT_NAME); |
Contributor
There was a problem hiding this comment.
Why do we need to wait for jdt.ls project import here?
Contributor
Author
There was a problem hiding this comment.
Rename operation is perform during the test. It fails when jdt.ls isn't started.
| public void prepare() throws Exception { | ||
| URL resource = getClass().getResource("/projects/git-pull-test"); | ||
| testUserPreferencesServiceClient.addGitCommitter(gitHubUsername, productUser.getEmail()); | ||
| URL resource = getClass().getResource("/projects/git-pull-test"); |
Contributor
There was a problem hiding this comment.
Random change or does this fix something?
| URL resource = getClass().getResource("/projects/git-pull-test"); | ||
| testProjectServiceClient.importProject( | ||
| ws.getId(), Paths.get(resource.toURI()), PROJECT_NAME, ProjectTemplates.MAVEN_SPRING); | ||
| ws.getId(), Paths.get(resource.toURI()), PROJECT_NAME, ProjectTemplates.NODE_JS); |
Contributor
There was a problem hiding this comment.
Again, why is this necessary?
Contributor
Author
There was a problem hiding this comment.
It isn't a maven project.
If we keep maven template then jdt.ls seems continuously import the project.
svor
approved these changes
Jul 16, 2018
tsmaeder
approved these changes
Jul 16, 2018
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
What does this PR do?
Fix selenium tests in
gitpackageWhat issues does this PR fix or reference?
#10431