Skip to content

Added more information in error output#10443

Merged
skabashnyuk merged 3 commits intomasterfrom
moreinfo
Jul 28, 2018
Merged

Added more information in error output#10443
skabashnyuk merged 3 commits intomasterfrom
moreinfo

Conversation

@skabashnyuk
Copy link
Copy Markdown
Contributor

What does this PR do?

Added more information in error output.
In ws-master logs after selenium test, I've noticed a lot of errors like this

2018-07-16 19:24:35,026[er-ThreadPool-2]  [ERROR] [e.c.w.i.k.n.p.PVCSubPathHelper 146]  - Job command '[rm, -rf, /tmp/job_mount/workspace1wfd4rtu91ncd9fm]' execution is failed.
2018-07-16 19:24:35,732[er-ThreadPool-1]  [ERROR] [e.c.w.i.k.n.p.PVCSubPathHelper 146]  - Job command '[rm, -rf, /tmp/job_mount/workspaceo9jme0bwa8ebxmjv]' execution is failed.

This PR is made to provide more details in such cases.

What issues does this PR fix or reference?

n/a

Added more information in error output.

Release Notes

Added more information in error output.

Docs PR

n/a

@skabashnyuk
Copy link
Copy Markdown
Contributor Author

ci-test

Copy link
Copy Markdown
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import io.fabric8.kubernetes.api.model.Pod;
import io.fabric8.kubernetes.api.model.PodBuilder;
import io.fabric8.kubernetes.api.model.Quantity;
import io.fabric8.kubernetes.api.model.*;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use an asterisk in imports?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean nice catch, we should not

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jul 17, 2018
@riuvshin
Copy link
Copy Markdown
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10443
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Copy Markdown
Contributor Author

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10443
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@riuvshin
Copy link
Copy Markdown
Contributor

@skabashnyuk is there any issues to get this merged?

@skabashnyuk skabashnyuk merged commit 871e033 into master Jul 28, 2018
@skabashnyuk skabashnyuk deleted the moreinfo branch July 28, 2018 17:12
@benoitf benoitf added this to the 6.9.0 milestone Jul 28, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement A feature request - must adhere to the feature request template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants