Simplify the theia stack from 2 machines to 1 with Theia only#10467
Merged
ashumilova merged 1 commit intomasterfrom Jul 19, 2018
Merged
Simplify the theia stack from 2 machines to 1 with Theia only#10467ashumilova merged 1 commit intomasterfrom
ashumilova merged 1 commit intomasterfrom
Conversation
ashumilova
added
the
status/code-review
benoitf
approved these changes
Jul 18, 2018
AndrienkoAleksandr
approved these changes
Jul 18, 2018
mmorhun
approved these changes
Jul 18, 2018
| "creator": "ide", | ||
| "name": "Java Theia (docker)", | ||
| "description": "Che development + Theia in a sidecar container (docker)", | ||
| "name": "Simple Theia (docker)", |
Contributor
There was a problem hiding this comment.
I would prefer to remove brackets, because stack validator says that the field is invalid (painful on copying the stack).
What about Theia on docker?
Contributor
Author
There was a problem hiding this comment.
Agree with you, maybe Theia IDE on docker?
Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
benoitf
removed
the
status/code-review
This was referenced Jul 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anna Shumilova ashumilo@redhat.com
What does this PR do?
Simplifies the Theia stack to contain only one Theia machine by removing dev-machine (which is not used in this case) and switching from compose to dockerimage recipe type. It works on Openshift as well.