Skip to content

Selenium: Finish creating the test methods in the 'UploadIntoProjectTest'#10475

Merged
artaleks9 merged 17 commits intomasterfrom
che-10204-advanced
Jul 21, 2018
Merged

Selenium: Finish creating the test methods in the 'UploadIntoProjectTest'#10475
artaleks9 merged 17 commits intomasterfrom
che-10204-advanced

Conversation

@artaleks9
Copy link
Copy Markdown
Contributor

@artaleks9 artaleks9 commented Jul 18, 2018

What does this PR do?

  • Add the test methods to the selenium test 'UploadIntoProjectTest'
  • Finish creating the test methods in the ''UploadIntoProjectTest'

What issues does this PR fix or reference?

#10204

Dmytro Nochevnov and others added 8 commits July 12, 2018 14:47
@artaleks9 artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Jul 18, 2018
@artaleks9 artaleks9 requested a review from vparfonov as a code owner July 18, 2018 14:45
@artaleks9
Copy link
Copy Markdown
Contributor Author

artaleks9 commented Jul 18, 2018

ci-test

Ohrimenko1988
Ohrimenko1988 reviewed Jul 18, 2018
View reviewed changes
...enium-test/src/test/java/org/eclipse/che/selenium/projectexplorer/UploadIntoProjectTest.java Outdated

// when re-upload the file
projectExplorer.waitAndSelectItem(PROJECT_NAME);

Copy link
Copy Markdown
Contributor

@Ohrimenko1988 Ohrimenko1988 Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if steps belong to one logical part "// when re-upload the file" better do not separate they by empty rows

Copy link
Copy Markdown
Contributor Author

@artaleks9 artaleks9 Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I'll correct

@artaleks9
Copy link
Copy Markdown
Contributor Author

artaleks9 commented Jul 18, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 18, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10475
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Copy Markdown
Contributor Author

artaleks9 commented Jul 19, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 19, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10475
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Copy Markdown
Contributor Author

artaleks9 commented Jul 19, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 19, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10475
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Copy Markdown
Contributor Author

artaleks9 commented Jul 20, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 20, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10475
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9 artaleks9 merged commit 249d858 into master Jul 21, 2018
@artaleks9 artaleks9 deleted the che-10204-advanced branch July 21, 2018 05:51
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 21, 2018
@benoitf benoitf added this to the 6.9.0 milestone Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

+1 more reviewer

@SkorikSergey SkorikSergey SkorikSergey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Milestone

6.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@artaleks9 @riuvshin @SkorikSergey @Ohrimenko1988 @benoitf