Skip to content

Add debug Id for content assistant widgets#10506

Merged
RomanNikitenko merged 1 commit intomasterfrom
contentAssistantDebugId
Jul 25, 2018
Merged

Add debug Id for content assistant widgets#10506
RomanNikitenko merged 1 commit intomasterfrom
contentAssistantDebugId

Conversation

@RomanNikitenko
Copy link
Copy Markdown
Member

@RomanNikitenko RomanNikitenko commented Jul 23, 2018

What does this PR do?

Add debug Ids for content assistant widgets to simplify selenium tests work

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

@RomanNikitenko
Add debug Id for content assistant widgets
adf07c3 
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 23, 2018

Can one of the admins verify this patch?

@RomanNikitenko
Copy link
Copy Markdown
Member Author

RomanNikitenko commented Jul 23, 2018

ci-test

@RomanNikitenko RomanNikitenko added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 23, 2018
@benoitf benoitf added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 23, 2018
@skryzhny
Copy link
Copy Markdown

skryzhny commented Jul 23, 2018

ci-test

1 similar comment
@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 23, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 24, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10506
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Copy Markdown
Contributor

SkorikSergey commented Jul 24, 2018

ci-test

1 similar comment
@mshaposhnik
Copy link
Copy Markdown
Contributor

mshaposhnik commented Jul 24, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 24, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10506
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@RomanNikitenko
Copy link
Copy Markdown
Member Author

RomanNikitenko commented Jul 25, 2018

ci-test

@SkorikSergey
Copy link
Copy Markdown
Contributor

SkorikSergey commented Jul 25, 2018

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/511/) doesn't show any regression against this Pull Request.

@RomanNikitenko RomanNikitenko added this to the 6.9.0 milestone Jul 25, 2018
@RomanNikitenko RomanNikitenko merged commit 3266f13 into master Jul 25, 2018
@RomanNikitenko RomanNikitenko deleted the contentAssistantDebugId branch July 25, 2018 09:28
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 25, 2018
@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 25, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10506
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vparfonov vparfonov vparfonov approved these changes

+1 more reviewer

@dkulieshov dkulieshov dkulieshov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/enhancement A feature request - must adhere to the feature request template.

Projects

None yet

Milestone

6.9.0

Development

Successfully merging this pull request may close these issues.

8 participants

@RomanNikitenko @riuvshin @skryzhny @SkorikSergey @mshaposhnik @dkulieshov @vparfonov @benoitf