Fix start of a workspace with Theia on k8s infra#10513
Merged
garagatyi merged 1 commit intoeclipse-che:masterfrom Jul 26, 2018
Merged
Fix start of a workspace with Theia on k8s infra#10513garagatyi merged 1 commit intoeclipse-che:masterfrom
garagatyi merged 1 commit intoeclipse-che:masterfrom
Conversation
When default-host strategy for server links evaluation is used on k8s infra Theia server has a link without trailing slash. This leads to a situation when Theia doesn't load because its main javascript is not loaded properly (URL gets truncated to parent and then name of the script is added). This PR adds a trailing slash to Theia server definition to fix this. Theia stack for Openshift recice is changed to align configuration of dockerimage and openshift stacks. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
benoitf
added
status/code-review
benoitf
approved these changes
Jul 23, 2018
ashumilova
approved these changes
Jul 26, 2018
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When default-host strategy for server links evaluation is used
on k8s infra Theia server has a link without trailing slash.
This leads to a situation when Theia doesn't load because its
main javascript is not loaded properly (URL gets truncated to
parent and then name of the script is added).
This PR adds a trailing slash to Theia server definition to
fix this.
Theia stack for Openshift recipe is changed to align
configuration of dockerimage and openshift stacks.
What issues does this PR fix or reference?
Release Notes
Docs PR