Selenium: cover Yaml language server functionality by selenium test#10525
Merged
SkorikSergey merged 15 commits intomasterfrom Jul 25, 2018
Merged
Selenium: cover Yaml language server functionality by selenium test#10525SkorikSergey merged 15 commits intomasterfrom
SkorikSergey merged 15 commits intomasterfrom
Conversation
…LanguageServer
…LanguageServer
…LanguageServer
…LanguageServer
SkorikSergey
added
status/in-progress
Contributor
Author
|
ci-test |
Contributor
|
ci-test build report: |
SkorikSergey
added
status/code-review
|
|
||
| public void launchCommentCodeFeature() { | ||
| Actions action = actionsFactory.createAction(seleniumWebDriver); | ||
| action.keyDown(CONTROL).sendKeys("/").keyUp(CONTROL).perform(); |
Contributor
There was a problem hiding this comment.
You may simplify:
actionsFactory.createAction(seleniumWebDriver)
.keyDown(CONTROL).sendKeys("/").keyUp(CONTROL).perform();
| .click(); | ||
| } | ||
|
|
||
| public void clickOnAddSchemaUrlButton() { |
Contributor
There was a problem hiding this comment.
please use "waitAndClick" method from "SeleniumWebDriverHelper"
| } | ||
|
|
||
| public void addSchemaUrl(String schemaName) { | ||
| new WebDriverWait(seleniumWebDriver, LOAD_PAGE_TIMEOUT_SEC) |
Contributor
There was a problem hiding this comment.
Use "SeleniumWebDriverHelper"
| new WebDriverWait(seleniumWebDriver, LOAD_PAGE_TIMEOUT_SEC) | ||
| .until(visibilityOf(addSchemaUrlInput)); | ||
| addSchemaUrlInput.sendKeys(schemaName); | ||
| new WebDriverWait(seleniumWebDriver, LOAD_PAGE_TIMEOUT_SEC) |
Contributor
There was a problem hiding this comment.
Use "SeleniumWebDriverHelper"
| editor.goToPosition(22, 1); | ||
| editor.launchCommentCodeFeature(); | ||
| editor.waitTextIntoEditor( | ||
| "# generation: 4\n" |
| editor.goToPosition(22, 1); | ||
| editor.launchCommentCodeFeature(); | ||
| editor.waitTextIntoEditor( | ||
| " generation: 4\n" |
Contributor
|
Don't forget to add the "YamlFileEditingTest" test to the suite xml. |
Ohrimenko1988
approved these changes
Jul 25, 2018
artaleks9
approved these changes
Jul 25, 2018
SkorikSergey
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates YamlFileEditingTest selenium test that cover the Yaml language server functionality by use cases from Language servers test plan - https://github.com/eclipse/che/wiki/Test-plan-for-checking-Language-servers.
What issues does this PR fix or reference?
#10442