Skip to content

Fix exceptions at opening an editor that does not correspond to an existing resource#10527

Merged
RomanNikitenko merged 1 commit intomasterfrom
CHE-10222
Jul 27, 2018
Merged

Fix exceptions at opening an editor that does not correspond to an existing resource#10527
RomanNikitenko merged 1 commit intomasterfrom
CHE-10222

Conversation

@RomanNikitenko
Copy link
Copy Markdown
Member

@RomanNikitenko RomanNikitenko commented Jul 24, 2018

What does this PR do?

  1. Do not track an editor on server side when this one does not correspond to an existing file system resource(command editor, effective pom and so on).
  2. Fix some exceptions(NPE when It is impossible to recognize a related project, IndexOutOfBoundsException when project path and file path are not related)

What issues does this PR fix or reference?

#10222 #8984 #9655
the PR does not fix #10309 (we should investigate this one), but allows to avoid first two errors described here

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

…isting resource

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jul 24, 2018
@riuvshin
Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@RomanNikitenko
Copy link
Copy Markdown
Member Author

ci-test

2 similar comments
@RomanNikitenko
Copy link
Copy Markdown
Member Author

ci-test

@mshaposhnik
Copy link
Copy Markdown
Contributor

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10527
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@RomanNikitenko
Copy link
Copy Markdown
Member Author

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10527
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vparfonov vparfonov requested a review from musienko-maxim July 25, 2018 16:38
@vparfonov
Copy link
Copy Markdown
Contributor

@musienko-maxim Can you check report, some regression in org.eclipse.che.selenium.intelligencecommand ?

@vkuznyetsov vkuznyetsov mentioned this pull request Jul 26, 2018
39 tasks
@RomanNikitenko RomanNikitenko added this to the 6.9.0 milestone Jul 27, 2018
@RomanNikitenko RomanNikitenko merged commit 183d411 into master Jul 27, 2018
@RomanNikitenko RomanNikitenko deleted the CHE-10222 branch July 27, 2018 07:17
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command removed after a freeze

7 participants