Simplify OpenShift/Kubernetes admin configuration#10529
Simplify OpenShift/Kubernetes admin configuration#10529amisevsk merged 1 commit intoeclipse-che:masterfrom
Conversation
Removes properties - che.infra.kubernetes.username : can change, requiring reconfiguration - che.infra.kubernetes.password : can change, requiring reconfiguration - che.infra.kubernetes.oauth_token : expires as they complicate setup and all represent suboptimal running scenarios. Use che serviceaccount instead. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
added
the
kind/bug
amisevsk
requested review from
benoitf,
garagatyi,
riuvshin and
skabashnyuk
as code owners
|
Can one of the admins verify this patch? |
benoitf
added
the
status/code-review
|
@eivantsov It is not clear to me whether you are approving docs or general approach or both or code. Could you elaborate on what your approval means? |
garagatyi
left a comment
garagatyi
left a comment
There was a problem hiding this comment.
Looks good! And the documentation PR is nice too!
|
ci-test |
|
This PR simplifies the way Che communicates with OpenShift/K8S API, so it's easy to explain how to configure Che for the 2 major scenarios: che SA and OpenShift v3 identity provider. So, +1. |
|
ci-test build report: |
|
@eclipse/eclipse-che-qa can you take a look on test results? |
|
Tests didn't show any regression. |
benoitf
removed
the
status/code-review
8 participants
What does this PR do?
Remove the properties
che.infra.kubernetes.usernameche.infra.kubernetes.passwordche.infra.kubernetes.oauth_tokenaccording to discussion in issue #9961 (comment)
As a result of this PR, the single-project use case of Che is simplified to just relying on the Che service account. This means that if workspaces are to be created in a different namespace, the service account will require cluster admin rights as noted in the updated docs PR.
What issues does this PR fix or reference?
#9961
Docs PR
eclipse-che/che-docs#439