Skip to content

Selenium: Fix logical mistakes in the "SeleniumWebDriverHelper" class methods#10556

Merged
Ohrimenko1988 merged 1 commit intomasterfrom
selen-10347
Aug 1, 2018
Merged

Selenium: Fix logical mistakes in the "SeleniumWebDriverHelper" class methods#10556
Ohrimenko1988 merged 1 commit intomasterfrom
selen-10347

Conversation

@Ohrimenko1988
Copy link
Copy Markdown
Contributor

@Ohrimenko1988 Ohrimenko1988 commented Jul 26, 2018

What does this PR do?

Fix logical mistakes in the "SeleniumWebDriverHelper" class methods

What issues does this PR fix or reference?

Issue: #10347

Release Notes

Docs PR

@Ohrimenko1988 Ohrimenko1988 added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/che-qe labels Jul 26, 2018
@Ohrimenko1988 Ohrimenko1988 requested a review from vparfonov as a code owner July 26, 2018 14:44
@Ohrimenko1988
Copy link
Copy Markdown
Contributor Author

Ohrimenko1988 commented Jul 27, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 27, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10556
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Copy Markdown
Contributor Author

Ohrimenko1988 commented Jul 27, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 27, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10556
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Copy Markdown
Contributor Author

Ohrimenko1988 commented Jul 27, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 27, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10556
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Copy Markdown
Contributor Author

Ohrimenko1988 commented Jul 30, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 30, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10556
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Copy Markdown
Contributor Author

Ohrimenko1988 commented Jul 30, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Jul 30, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10556
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988 Ohrimenko1988 merged commit 266b916 into master Aug 1, 2018
@Ohrimenko1988 Ohrimenko1988 deleted the selen-10347 branch August 1, 2018 08:05
@Ohrimenko1988 Ohrimenko1988 mentioned this pull request Aug 1, 2018
Closed
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 1, 2018
@benoitf benoitf added this to the 6.9.0 milestone Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@artaleks9 artaleks9 artaleks9 approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

+1 more reviewer

@SkorikSergey SkorikSergey SkorikSergey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Milestone

6.9.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Ohrimenko1988 @riuvshin @musienko-maxim @artaleks9 @SkorikSergey @benoitf