Selenium: Create test 'ImportAndValidateEclipseCheProjectTest' by artaleks9 · Pull Request #10558 · eclipse-che/che

artaleks9 · 2018-07-26T16:06:16Z

What does this PR do?

Create the selenium test 'ImportAndValidateEclipseCheProjectTest'
Correct the methods in the 'InformationDialog' using the 'SeleniumWebDriverHelper'
Correct the methods in the 'MavenPluginStatusBar' using the 'SeleniumWebDriverHelper'

What issues does this PR fix or reference?

#10107

…DriverHelper'

…WebDriverHelper'

artaleks9 · 2018-07-26T16:06:53Z

ci-test

riuvshin · 2018-07-26T21:29:41Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10558
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Ohrimenko1988 · 2018-07-27T08:56:04Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+    // TODO it is the workaround, delete it after resolve the issue
+    // TODO https://github.com/eclipse/che/issues/10515
+    // close unexpected error information dialog and click on the 'Save' button;
+    int counterErrorDialog = 0;


please encapsulate this logic to the method for more readability

Even more. Better to use the next construction:

webDriverWaitFactory.get().until((ExpectedCondition<Boolean>) driver -> { informationDialog.waitFormToOpen(); informationDialog.clickOkBtn(); projectWizard.clickSaveButton(); loader.waitOnClosed(); return informationDialog.waitFormIsOpened(); });

In this case we explicitely provide time for event waiting.
In case of using "while" the infinite loop is possible.

Ohrimenko1988 · 2018-07-27T09:06:16Z

...m/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/InformationDialog.java

+    seleniumWebDriverHelper.waitVisibility(dialogForm);
+  }
+
+  public boolean waitFormIsOpened() {


isFormOpened()

Ohrimenko1988 · 2018-07-27T09:13:28Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+      loader.waitOnClosed();
+    }
+
+    System.out.println(


Looks redundant.

Ohrimenko1988 · 2018-07-27T09:16:29Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+    // then open files
+    // open a java file
+    projectExplorer.quickRevealToItemWithJavaScript(
+        String.format("%s/%s", PROJECT_NAME, PATH_TO_JAVA_FILE));


What about creating the constant for this path?

Ohrimenko1988 · 2018-07-27T09:16:44Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+
+    // open a xml file
+    projectExplorer.quickRevealToItemWithJavaScript(
+        String.format("%s/%s", PROJECT_NAME, PATH_TO_POM_FILE));


Ohrimenko1988 · 2018-07-27T09:17:09Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+
+    // open a ts file
+    projectExplorer.quickRevealToItemWithJavaScript(
+        String.format("%s/%s", PROJECT_NAME, PATH_TO_TS_FILE));


Ohrimenko1988 · 2018-07-27T09:18:12Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+
+    // open the resolving dependencies form
+    loader.waitOnClosed();
+    mavenPluginStatusBar.waitExpectedTextInInfoPanel("Resolving project:", 120);


Please create variable or constant which describes this "magic number". I mean "120"

Ohrimenko1988 · 2018-07-27T09:18:30Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+    mavenPluginStatusBar.waitResolveDependenciesFormToOpen();
+
+    // wait while dependencies are resolved
+    mavenPluginStatusBar.waitClosingInfoPanel(2900);


Magic number

Ohrimenko1988 · 2018-07-27T09:19:02Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+  @Test(priority = 1)
+  public void checkErrorMarkersInEditor() {
+    // check an error marker in the pom.xml file
+    projectExplorer.openItemByPath(String.format("%s/%s", PROJECT_NAME, PATH_TO_POM_FILE));


Ohrimenko1988 · 2018-07-27T09:19:31Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+    editor.waitMarkerInvisibility(ERROR, 12);
+
+    // check error marker in the ts file
+    projectExplorer.openItemByPath(String.format("%s/%s", PROJECT_NAME, PATH_TO_TS_FILE));


Ohrimenko1988 · 2018-07-27T13:48:12Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java


  @Test
  public void checkImportAndResolveDependenciesEclipceCheProject() {
+    int timeoutToOpenInfoPanel = 120;


they should be "final"

final int timeoutToOpenInfoPanel = 120; final int timeoutToClosingInfoPanel = 2900;

Ohrimenko1988 · 2018-07-27T13:54:22Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

-    projectExplorer.quickRevealToItemWithJavaScript(
-        String.format("%s/%s", PROJECT_NAME, PATH_TO_POM_FILE));
-    projectExplorer.openItemByPath(String.format("%s/%s", PROJECT_NAME, PATH_TO_POM_FILE));
+    projectExplorer.quickRevealToItemWithJavaScript(PATH_TO_POM_FILE);


this place repeats several times:

projectExplorer.quickRevealToItemWithJavaScript( ... ); projectExplorer.openItemByPath( ... );

what about to create a private method in the test or public method in the "ProjectExplorer" which will encapsulate this two methods, something like that:

private void quickRevealToItemWithJavaScriptAndOpenFile(String pathToItem){ projectExplorer.quickRevealToItemWithJavaScript(pathToItem); projectExplorer.openItemByPath(pathToItem); }

I agree. I think it is better to do in the test.

Ohrimenko1988 · 2018-07-27T14:00:07Z

...est/src/test/java/org/eclipse/che/selenium/stack/ImportAndValidateEclipseCheProjectTest.java

+
+      if (counterErrorDialog > 5) {
+
+        Assert.assertEquals(


"assertEquals" looks redundant, in my opinion, "Assert.fail()" is better to use in this case:

fail("The unexpected error information dialog is appeared more than "+ counterErrorDialog +" times");

artaleks9 added 7 commits July 24, 2018 17:32

Create the selenium test 'ImportAndValidateEclipseCheProjectTest'

92fbe98

Correct the methods in the 'InformationDialog' using the 'SeleniumWeb…

8d2a33f

…DriverHelper'

Correct the methods in the 'MavenPluginStatusBar' using the 'Selenium…

0f7350c

…WebDriverHelper'

Merge branch 'master' of github.com:eclipse/che into che#10107

1a10e93

Modified the 'ImportAndValidateEclipseCheProjectTest'

2a9aa17

Merge branch 'master' of github.com:eclipse/che into che#10107

35d9908

Add changes to the 'ImportAndValidateEclipseCheProjectTest'

1f08ff5

artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Jul 26, 2018

artaleks9 requested review from Ohrimenko1988, SkorikSergey and musienko-maxim July 26, 2018 16:06

artaleks9 requested a review from vparfonov as a code owner July 26, 2018 16:06

Ohrimenko1988 reviewed Jul 27, 2018

View reviewed changes

artaleks9 added 3 commits July 27, 2018 14:09

Merge branch 'master' of github.com:eclipse/che into che#10107

24fbd49

Merge branch 'master' of github.com:eclipse/che into che#10107

fc0ffd2

Add correctiions according to review

9808b2a

SkorikSergey approved these changes Jul 27, 2018

View reviewed changes

Ohrimenko1988 reviewed Jul 27, 2018

View reviewed changes

Correct the parameter of the variable

b334521

Ohrimenko1988 reviewed Jul 27, 2018

View reviewed changes

Add correction in the test

a8c7acd

Ohrimenko1988 approved these changes Jul 27, 2018

View reviewed changes

artaleks9 merged commit 77b39fc into master Jul 27, 2018

artaleks9 deleted the che#10107 branch July 27, 2018 14:49

benoitf added this to the 6.9.0 milestone Jul 27, 2018

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 27, 2018

Conversation

artaleks9 commented Jul 26, 2018

What does this PR do?

What issues does this PR fix or reference?

Uh oh!

artaleks9 commented Jul 26, 2018

Uh oh!

riuvshin commented Jul 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ohrimenko1988 Jul 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ohrimenko1988 Jul 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Ohrimenko1988 Jul 27, 2018 •

edited

Loading

Ohrimenko1988 Jul 27, 2018 •

edited

Loading