Skip to content

Loader fix#10619

Merged
mshaposhnik merged 4 commits intomasterfrom
loader_fix
Aug 2, 2018
Merged

Loader fix#10619
mshaposhnik merged 4 commits intomasterfrom
loader_fix

Conversation

@mshaposhnik
Copy link
Copy Markdown
Contributor

@mshaposhnik mshaposhnik commented Aug 1, 2018 •
edited
Loading

What does this PR do?

Contains loader.html fixes for correct reridectUrl validation (check if any server url is a subpart or a redirectUrl)

What issues does this PR fix or reference?

#10349

@skabashnyuk skabashnyuk requested a review from akurinnoy August 1, 2018 11:49
@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Aug 1, 2018
@mshaposhnik
Copy link
Copy Markdown
Contributor Author

mshaposhnik commented Aug 1, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 1, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10619
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mshaposhnik
Copy link
Copy Markdown
Contributor Author

mshaposhnik commented Aug 2, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 2, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10619
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mshaposhnik mshaposhnik merged commit 5446e00 into master Aug 2, 2018
@mshaposhnik mshaposhnik deleted the loader_fix branch August 2, 2018 13:05
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 9, 2018
@benoitf benoitf added this to the 6.10.0 milestone Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

No one assigned

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Milestone

6.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mshaposhnik @riuvshin @skabashnyuk @akurinnoy @benoitf