Set Che QE team members as owners of selenium tests sub-project#10622
Merged
dmytro-ndp merged 1 commit intomasterfrom Aug 1, 2018
Merged
Set Che QE team members as owners of selenium tests sub-project#10622dmytro-ndp merged 1 commit intomasterfrom
dmytro-ndp merged 1 commit intomasterfrom
Conversation
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
vparfonov
approved these changes
Aug 1, 2018
benoitf
added
status/code-review
gazarenkov
approved these changes
Aug 1, 2018
Contributor
gazarenkov
left a comment
gazarenkov
left a comment
There was a problem hiding this comment.
I would prefer to have more fine grained codeownership
i.e. one person (2 max) per piece, but it's better then nothing anyways
skabashnyuk
approved these changes
Aug 1, 2018
vkuznyetsov
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It sets next members of Che QE team as an owners of Eclipse Che E2E selenium tests situated in the sub-project che/selenium: @musienko-maxim, @dmytro-ndp, @Ohrimenko1988
What issues does this PR fix or reference?
It will prevent from merging unchecked changes into selenium tests which could cause regression like the follow #10612 into the master branch.