Selenium: cover Golang language server functionality by selenium test #10625
Merged
SkorikSergey merged 10 commits intomasterfrom Aug 6, 2018
Merged
Selenium: cover Golang language server functionality by selenium test #10625SkorikSergey merged 10 commits intomasterfrom
SkorikSergey merged 10 commits intomasterfrom
Conversation
…angLSFunctionality
…angLSFunctionality
SkorikSergey
added
status/in-progress
SkorikSergey
requested review from
Ohrimenko1988,
dmytro-ndp and
musienko-maxim
as code owners
Contributor
Author
|
ci-build |
SkorikSergey
added
status/code-review
…angLSFunctionality
dmytro-ndp
reviewed
Aug 3, 2018
|
|
||
| @Test(priority = 1) | ||
| public void checkCodeValidation() { | ||
| editor.selectTabByName(GO_FILE_NAME); |
Contributor
There was a problem hiding this comment.
From the readability view it's better to divide separate steps by empty rows.
dmytro-ndp
reviewed
Aug 3, 2018
| editor.waitAllMarkersInvisibility(ERROR); | ||
| editor.goToCursorPositionVisible(13, 1); | ||
| editor.typeTextIntoEditor("p"); | ||
| editor.waitMarkerInPosition(ERROR, 13); |
Contributor
There was a problem hiding this comment.
IMHO it's important to check error message as well.
dmytro-ndp
approved these changes
Aug 6, 2018
|
|
||
| @Test | ||
| public void checkLanguageServerInitialized() { | ||
| projectExplorer.waitAndSelectItem(PROJECT_NAME); |
Contributor
There was a problem hiding this comment.
projectExplorer.waitAndSelectItem(PROJECT_NAME);
projectExplorer.openItemByPath(PROJECT_NAME);
projectExplorer.openItemByPath(PATH_TO_GO_FILE);
Can be changed to "ProjectExplorer#expandPathInProjectExplorerAndOpenFile(String path, String fileName)"
Contributor
There was a problem hiding this comment.
Can we apply quickExpandWithJavaScript()? For reducing of opening time.
| editor.launchAutocompleteAndWaitContainer(); | ||
|
|
||
| editor.checkProposalDocumentation("No documentation found."); | ||
| editor.waitTextIntoAutocompleteContainer("Print"); |
Contributor
There was a problem hiding this comment.
maybe we should works this method for using of multiple arguments:
CodenvyEditor#waitTextIntoAutocompleteContainer(String ... expectedText);
It helps to reach more compact syntax:
editor.waitTextIntoAutocompleteContainer("Print", "Println", "Printf");
what do you think about this?
Ohrimenko1988
approved these changes
Aug 6, 2018
dmytro-ndp
approved these changes
Aug 6, 2018
SkorikSergey
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates GolangFileEditingTest selenium test that cover the Golang language server functionality by use cases from Language servers test plan - https://github.com/eclipse/che/wiki/Test-plan-for-checking-Language-servers.
What issues does this PR fix or reference?
#10084