Skip to content

Add ability to get File Type by provider and avoid File Type collision#10640

Merged
RomanNikitenko merged 1 commit intomasterfrom
CHE-9467
Aug 17, 2018
Merged

Add ability to get File Type by provider and avoid File Type collision#10640
RomanNikitenko merged 1 commit intomasterfrom
CHE-9467

Conversation

@RomanNikitenko
Copy link
Copy Markdown
Member

@RomanNikitenko RomanNikitenko commented Aug 2, 2018 •
edited
Loading

What does this PR do?

  • add ability to get File Type by provider and avoid File Type collision.
  • clean up Language Server Registry and Editor Registry when a workspace is stopped or Ws agent server is stopped

What issues does this PR fix or reference?

#9467
Signed-off-by: Roman Nikitenko rnikiten@redhat.com

@RomanNikitenko RomanNikitenko added kind/bug Outline of a bug - must adhere to the bug report template. status/in-progress This issue has been taken by an engineer and is under active development. labels Aug 2, 2018
@RomanNikitenko
Copy link
Copy Markdown
Member Author

RomanNikitenko commented Aug 2, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 3, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10640
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@RomanNikitenko
Copy link
Copy Markdown
Member Author

RomanNikitenko commented Aug 6, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 6, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10640
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@RomanNikitenko
Copy link
Copy Markdown
Member Author

RomanNikitenko commented Aug 12, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 13, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10640
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@RomanNikitenko
Copy link
Copy Markdown
Member Author

RomanNikitenko commented Aug 14, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 14, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10640
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@musienko-maxim
Copy link
Copy Markdown
Contributor

musienko-maxim commented Aug 16, 2018

The existed selenium tests did not find new regression

@RomanNikitenko RomanNikitenko changed the title [WIP] Add ability to detect and handle collisions at file type registration Add ability to get File Type by provider and avoid File Type collision Aug 16, 2018
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Aug 16, 2018
@RomanNikitenko
CHE-9467. Add ability to get File Type by provider and avoid File Typ…
8d12174 
…e collision

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko added this to the 6.10.0 milestone Aug 17, 2018
@RomanNikitenko RomanNikitenko merged commit 93b0ffe into master Aug 17, 2018
@RomanNikitenko RomanNikitenko deleted the CHE-9467 branch August 17, 2018 12:26
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 17, 2018
@SkorikSergey SkorikSergey mentioned this pull request Aug 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vparfonov vparfonov vparfonov approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

+1 more reviewer

@dkulieshov dkulieshov dkulieshov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Milestone

6.10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@RomanNikitenko @riuvshin @musienko-maxim @dkulieshov @vparfonov