Skip to content

CHE-10538: improves workspace loader#10642

Merged
akurinnoy merged 3 commits intoeclipse-che:masterfrom
akurinnoy:CHE-10538
Aug 7, 2018
Merged

CHE-10538: improves workspace loader#10642
akurinnoy merged 3 commits intoeclipse-che:masterfrom
akurinnoy:CHE-10538

Conversation

@akurinnoy
Copy link
Copy Markdown
Contributor

@akurinnoy akurinnoy commented Aug 3, 2018

What does this PR do?

When workspace loader starts a workspace and it fails, then an error appears and the progress bar hides.

restart

What issues does this PR fix or reference?

fix #10538

Release Notes

N/A - bugfix

Docs PR

N/A - bugfix

@akurinnoy
CHE-10538: update workspace loading flow
7efa88f 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
update licenses
67a26ed 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy akurinnoy added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Aug 3, 2018
@akurinnoy akurinnoy self-assigned this Aug 3, 2018
@akurinnoy akurinnoy requested a review from vparfonov as a code owner August 3, 2018 06:11
@akurinnoy
Copy link
Copy Markdown
Contributor Author

akurinnoy commented Aug 3, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 3, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10642
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@akurinnoy
Copy link
Copy Markdown
Contributor Author

akurinnoy commented Aug 3, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 3, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10642
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@akurinnoy
Copy link
Copy Markdown
Contributor Author

akurinnoy commented Aug 6, 2018

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 6, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10642
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vkuznyetsov vkuznyetsov mentioned this pull request Aug 6, 2018
Closed
20 tasks
@SkorikSergey
Copy link
Copy Markdown
Contributor

SkorikSergey commented Aug 7, 2018

Selenium tests execution on Eclipse Che Multiuser on OCP (lhttps://ci.codenvycorp.com/job/che-pullrequests-test-ocp/550/) doesn't show any regression against this Pull Request.

@akurinnoy akurinnoy merged commit b03be67 into eclipse-che:master Aug 7, 2018
@akurinnoy akurinnoy mentioned this pull request Aug 7, 2018
Merged
@sleshchenko sleshchenko mentioned this pull request Aug 8, 2018
Closed
@benoitf benoitf added this to the 6.10.0 milestone Aug 9, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 9, 2018
@akurinnoy akurinnoy deleted the CHE-10538 branch August 23, 2018 10:19
skabashnyuk pushed a commit to skabashnyuk/che that referenced this pull request Mar 11, 2020
@akurinnoy
CHE-10538: improves workspace loader (eclipse-che#10642)
8392ed0 
* CHE-10538: update workspace loading flow

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* update licenses

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! CHE-10538: update workspace loading flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoitf benoitf benoitf approved these changes

@vitaliy-guliy vitaliy-guliy vitaliy-guliy approved these changes

@ashumilova ashumilova Awaiting requested review from ashumilova

@vparfonov vparfonov Awaiting requested review from vparfonov

+1 more reviewer

@SkorikSergey SkorikSergey SkorikSergey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@akurinnoy akurinnoy

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Milestone

6.10.0

Development

Successfully merging this pull request may close these issues.

Workspace-loader app should show error when request to start a workspace fails

5 participants

@akurinnoy @riuvshin @SkorikSergey @benoitf @vitaliy-guliy