Skip to content

Update fmt plugin to latest to enable skipping check #10554#10667

Merged
tolusha merged 1 commit intoeclipse-che:masterfrom
vrubezhny:che10554
Aug 8, 2018
Merged

Update fmt plugin to latest to enable skipping check #10554#10667
tolusha merged 1 commit intoeclipse-che:masterfrom
vrubezhny:che10554

Conversation

@vrubezhny
Copy link
Copy Markdown
Contributor

The files are reformatted in order to suit the requirements of coveo maven fmt plug-in of v.2.5.1

Signed-off-by: Victor Rubezhny vrubezhny@redhat.com

What does this PR do?

The PR contains all the classes that are reformatted in order to suit the requirements of coveo maven fmt plug-in of v.2.5.1

What issues does this PR fix or reference?

Depends on eclipse-che/che-parent#67

Release Notes

Docs PR

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 3, 2018

Can one of the admins verify this patch?

@skabashnyuk
Copy link
Copy Markdown
Contributor

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

riuvshin commented Aug 4, 2018

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10667
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vrubezhny
Copy link
Copy Markdown
Contributor Author

This PR depends on eclipse-che/che-parent#67 and cannot be built successfully without applying the mentioned PR first.

@dmytro-ndp
Copy link
Copy Markdown
Contributor

@vrubezhny: PR selenium tests job ought to take into account upstream project che-parent in usual cases, but now it have been skipped with resolution:
>>>>>> Pull request is issued from fork, skipping upstream project branch checks <<<<<<
As a result, test build failed:

14:00:32 [INFO] Processed 33 files (2 non-complying).
14:00:32 [ERROR] Found 2 non-complying files, failing build
14:00:32 [ERROR] Non complying file: /home/codenvy/workspace/che-pullrequests-test-ocp/core/che-core-api-dto/src/test/java/org/eclipse/che/dto/definitions/DtoWithDelegate.java
14:00:32 [ERROR] Non complying file: /home/codenvy/workspace/che-pullrequests-test-ocp/core/che-core-api-dto/src/test/java/org/eclipse/che/dto/ServerDtoTest.java

@riuvshin: it's interesting to know why PR selenum tests job skips upstream projects branches in case of PR is from the fork?

The files are reformatted in order to suit the requirements of coveo maven fmt plug-in of v.2.5.1

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny
Copy link
Copy Markdown
Contributor Author

The PR's commit is rebased and updated

@tolusha
Copy link
Copy Markdown
Contributor

tolusha commented Aug 8, 2018

@dmytro-ndp
Do we have your approval?

Copy link
Copy Markdown
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from the point of selenium tests codebase so as test resources haven't been changed.

@tolusha tolusha added kind/task Internal things, technical debt, and to-do tasks to be performed. team/languages labels Aug 8, 2018
Copy link
Copy Markdown
Contributor

@tolusha tolusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully built che-parent che-docs che-libs and che projects

@tolusha tolusha merged commit 57c43ac into eclipse-che:master Aug 8, 2018
@benoitf benoitf added this to the 6.10.0 milestone Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants